Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable authorization directives by default #3713

Merged
merged 26 commits into from
Oct 23, 2023
Merged

Enable authorization directives by default #3713

merged 26 commits into from
Oct 23, 2023

Conversation

Geal
Copy link
Contributor

@Geal Geal commented Aug 31, 2023

Fix #3842

This requires a few steps, because authorization directives should not be usable without a valid license, so the license enforcement code has to check for their presence in the graph.

One missing point: making sure that the authorization plugins can recognize when their directives have been renamed (extracted in another PR: #3949)

Checklist

Complete the checklist (and note appropriate exceptions) before a final PR is raised.

  • Changes are compatible[^1]
  • Documentation[^2] completed
  • Performance impact assessed and acceptable
  • Tests added and passing[^3]
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

[^1]. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.
[^2]. Configuration is an important part of many changes. Where applicable please try to document configuration examples.
[^3]. Tick whichever testing boxes are applicable. If you are adding Manual Tests:
- please document the manual testing (extensively) in the Exceptions.
- please raise a separate issue to automate the test and label it (or ask for it to be labeled) as manual test

@github-actions

This comment has been minimized.

@router-perf
Copy link

router-perf bot commented Aug 31, 2023

CI performance tests

  • step - Basic stress test that steps up the number of users over time
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • const - Basic stress test that runs with a constant number of users
  • reload - Reload test over a long period of time at a constant rate of users
  • large-request - Stress test with a 1 MB request payload
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • no-graphos - Basic stress test, no GraphOS.

@Meschreiber Meschreiber requested a review from a team as a code owner September 6, 2023 19:29
@Geal Geal requested review from a team, SimonSapin, bnjjj and lrlna October 2, 2023 10:39
@Geal Geal changed the title enable authorization directives by default Enable authorization directives by default Oct 2, 2023
Geal added a commit that referenced this pull request Oct 23, 2023
Extracted from #3713

When importing directives through the `@link` directive, they can be
renamed. This makes sure that the authorization plugin can still
recognize its directives when they have been renamed
@Geal Geal requested a review from o0Ignition0o October 23, 2023 07:28
.changesets/feat_geal_authz_optout.md Outdated Show resolved Hide resolved
@Geal Geal enabled auto-merge (squash) October 23, 2023 08:26
@Geal Geal merged commit 0e51563 into dev Oct 23, 2023
1 of 2 checks passed
@Geal Geal deleted the geal/authz-optout branch October 23, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable authorization directives by default
4 participants