Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable authorization directives by default #3842

Closed
Geal opened this issue Sep 18, 2023 · 0 comments · Fixed by #3713
Closed

Enable authorization directives by default #3842

Geal opened this issue Sep 18, 2023 · 0 comments · Fixed by #3713
Assignees
@Geal
Labels
component/auth

Comments

@Geal
Copy link
Contributor

Geal commented Sep 18, 2023

Authorization directives should be enabled by default if a valid entitlement is detected. This changes a bit the behaviour of the entitlement check, because it has to check for the presence of the directive in the graph, and must be robust against directive renaming
@Geal Geal mentioned this issue Sep 18, 2023
Merged
6 tasks
@Geal Geal self-assigned this Oct 2, 2023
Geal added a commit that referenced this issue Oct 23, 2023
@Geal @Meschreiber @o0Ignition0o
Enable authorization directives by default (#3713)
0e51563 
Fix #3842 

This requires a few steps, because authorization directives should not
be usable without a valid license, so the license enforcement code has
to check for their presence in the graph.

Co-authored-by: Maria Elisabeth Schreiber <[email protected]>
Co-authored-by: Jeremy Lempereur <[email protected]>
@goto-bus-stop goto-bus-stop mentioned this issue Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Geal Geal

Labels
component/auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable authorization directives by default apollographql/router
1 participant
@Geal