Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for enterprise features in the schema #3866

Closed
Geal opened this issue Sep 21, 2023 · 1 comment
Closed

Check for enterprise features in the schema #3866

Geal opened this issue Sep 21, 2023 · 1 comment
Assignees

Comments

@Geal
Copy link
Contributor

Geal commented Sep 21, 2023

So far, the enterprise features check only covers the presence of specific configuration option, but we're moving towards enterprise features carried by directives, so only present in the schema. We need the feature check to look at the schema and:

  • detect enterprise directives, even if imported under a different name
  • detect if the directives are actually used (not just present)
  • refuse to load the schema if the directives are used but no valid license is found

We can have a later check in plugins to refuse to load if the feature is disabled in configuration

@Geal Geal self-assigned this Oct 24, 2023
@Geal
Copy link
Contributor Author

Geal commented Oct 24, 2023

Fixed by #3713

@Geal Geal closed this as completed Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant