Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prototype, make span using dynamic attributes #4086

Closed
Tracked by #3226
BrynCooke opened this issue Oct 23, 2023 · 1 comment · Fixed by #4102
Closed
Tracked by #3226

Prototype, make span using dynamic attributes #4086

BrynCooke opened this issue Oct 23, 2023 · 1 comment · Fixed by #4102
Assignees
@BrynCooke @bnjjj

Comments

@BrynCooke
Copy link
Contributor

BrynCooke commented Oct 23, 2023 •
edited
Loading

Make a span using dynamic attributes.
This should have more than 32 attributes and use some leaked strings.

Manually create a FieldSet, use it to create a span.
@BrynCooke BrynCooke mentioned this issue Oct 23, 2023
Open
28 tasks
@BrynCooke
Copy link
Contributor Author

We've decided to go for:

  1. Store an DynAttributes structure in tracing via the registry.
  2. Create a layer that will pick up extra attributes and put them on events.

@BrynCooke BrynCooke reopened this Oct 25, 2023
@bnjjj bnjjj mentioned this issue Nov 10, 2023
Merged
6 tasks
Geal pushed a commit that referenced this issue Nov 29, 2023
@bnjjj
Add support for custom attributes for spans and logs (#4102)
3fa7c11 
Fixes #4096
Fixes #4086
Fixes #3543
Fixes #3537


---------

Signed-off-by: Benjamin Coenen <[email protected]>
Co-authored-by: bryn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrynCooke BrynCooke

@bnjjj bnjjj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for custom attributes for spans and logs apollographql/router
2 participants
@BrynCooke @bnjjj