Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to add datadog_trace_id in addition to trace_id #3537

Closed
BrynCooke opened this issue Aug 4, 2023 · 2 comments · Fixed by #4102
Closed

Add option to add datadog_trace_id in addition to trace_id #3537

BrynCooke opened this issue Aug 4, 2023 · 2 comments · Fixed by #4102
Assignees
@BrynCooke

Comments

@BrynCooke
Copy link
Contributor

Datadog has a numeric trace ID format. For correlation of logs to work we need to add a datadog_trace_id in the same way that we add trace_id.

The conversion from otel to dd traceid is documented here: https://docs.datadoghq.com/tracing/other_telemetry/connect_logs_and_traces/opentelemetry/?tab=python
@abernix
Copy link
Member

abernix commented Aug 14, 2023

This might solve #2402.

@abernix abernix mentioned this issue Aug 14, 2023
Open
@BrynCooke BrynCooke self-assigned this Aug 31, 2023
@BrynCooke
Copy link
Contributor Author

This is related to #3226.

The plan is to get some sort of agreement as to where this should fit in to our config and work towards this.

@bnjjj bnjjj mentioned this issue Nov 10, 2023
Merged
6 tasks
Geal pushed a commit that referenced this issue Nov 29, 2023
@bnjjj
Add support for custom attributes for spans and logs (#4102)
3fa7c11 
Fixes #4096
Fixes #4086
Fixes #3543
Fixes #3537


---------

Signed-off-by: Benjamin Coenen <[email protected]>
Co-authored-by: bryn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrynCooke BrynCooke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for custom attributes for spans and logs apollographql/router
2 participants
@BrynCooke @abernix