Remove most exceptions to TS strict rules #5171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glasser
force-pushed
the
glasser/upgrade-ts-typecheck-tests
branch
from
2d7e8e3
to
39263a3
Compare
glasser
force-pushed
the
glasser/stricter-ts
branch
from
8c166b4
to
66c633d
Compare
Changing to an async function seemed like the easiest approach here.
`this.playgroundVersion` doesn't really seem to be a thing, so that line was just extraneous.
The field types are copied from GraphQLError and Error.
Normally I'd be a bit wary of adding a bunch of `!` to non-test code, but it's no worse than the status quo with strictNullChecks false.
Technically this is not a no-op if you have `this.requestOptions.parseOptions`, but the parseOptions line wasn't there at all when this workaround was originally added in #1126 (I don't remember exactly what was going on here but I assume it was "doesn't compile without these extra lines".)
glasser
force-pushed
the
glasser/stricter-ts
branch
from
66c633d
to
9ba0df6
Compare
|
@martijnwalraven Eventual review would be appreciated, but I'm merging today for velocity. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review individual commits.
Addresses #5170. Does not fully resolve it because there's a few left in hapi and koa that I'll fix as part of #4966.