Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AS3: Remove exceptions to TS strict mode #5170

Closed
glasser opened this issue May 4, 2021 · 1 comment
Closed

AS3: Remove exceptions to TS strict mode #5170

glasser opened this issue May 4, 2021 · 1 comment

Comments

@glasser
Copy link
Member

glasser commented May 4, 2021

No description provided.

@glasser glasser mentioned this issue May 4, 2021
Merged
glasser added a commit that referenced this issue May 5, 2021
@glasser
apollo-server-koa: enable noImplicitAny and strictNullChecks
2efd4a3 
The simplest way to implement this was to inline graphqlKoa (only
exported in Apollo Server 1) into ApolloServer, and change the main
middleware to be explicitly `async` instead of "sometimes `return;` and
sometimes return a Promise".

There's a slight change to error handling in that the newly introduced
`catch` clause also catches anything thrown by the couple of lines after
`runHttpQuery` that processes its output, but that's probably a good
change.

Part of #5170.
This was referenced May 5, 2021
Closed
Merged
glasser added a commit that referenced this issue May 5, 2021
@glasser
apollo-server-koa: enable noImplicitAny and strictNullChecks (#5177)
bc382e6 
The simplest way to implement this was to inline graphqlKoa (only
exported in Apollo Server 1) into ApolloServer, and change the main
middleware to be explicitly `async` instead of "sometimes `return;` and
sometimes return a Promise".

There's a slight change to error handling in that the newly introduced
`catch` clause also catches anything thrown by the couple of lines after
`runHttpQuery` that processes its output, but that's probably a good
change.

Part of #5170.
glasser added a commit that referenced this issue May 5, 2021
@glasser
apollo-server-hapi: enable noImplicitAny and strictNullChecks
a8eb916 
As in #5177, the easiest way is to inline hapiApollo (AS1 API) into
ApolloServer.ts.

Also remove some unnecessary `await`s.

Fixes #5170.
@glasser glasser mentioned this issue May 5, 2021
Merged
glasser added a commit that referenced this issue May 5, 2021
@glasser
apollo-server-hapi: enable noImplicitAny and strictNullChecks (#5178)
93d586b 
As in #5177, the easiest way is to inline hapiApollo (AS1 API) into
ApolloServer.ts.

Also remove some unnecessary `await`s.

Fixes #5170.
@glasser
Copy link
Member Author

glasser commented May 5, 2021

Fixed on release-3.0.

@glasser glasser closed this as completed May 5, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@glasser