Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove most exceptions to TS strict rules #5171

Merged
merged 6 commits into from
May 5, 2021
Merged

Remove most exceptions to TS strict rules #5171

merged 6 commits into from
May 5, 2021

Commits on May 5, 2021

  1. apollo-server-koa: enable noImplicitReturns 

    Changing to an async function seemed like the easiest approach here.
    @glasser
    glasser committed May 5, 2021
    Configuration menu
    Copy the full SHA
    b2f3953 View commit details
    Browse the repository at this point in the history

  2. apollo-server-hapi: enable noImplicitThis 

    `this.playgroundVersion` doesn't really seem to be a thing, so that line was
just extraneous.
    @glasser
    glasser committed May 5, 2021
    Configuration menu
    Copy the full SHA
    45c1031 View commit details
    Browse the repository at this point in the history

  3. apollo-server-errors: enable noImplicitAny 

    The field types are copied from GraphQLError and Error.
    @glasser
    glasser committed May 5, 2021
    Configuration menu
    Copy the full SHA
    df1b539 View commit details
    Browse the repository at this point in the history

  4. apollo-server-integration-testsuite: fully strict

    @glasser
    glasser committed May 5, 2021
    Configuration menu
    Copy the full SHA
    640a746 View commit details
    Browse the repository at this point in the history

  5. apollo-server-micro: fully strict 

    Normally I'd be a bit wary of adding a bunch of `!` to non-test code,
but it's no worse than the status quo with strictNullChecks false.
    @glasser
    glasser committed May 5, 2021
    Configuration menu
    Copy the full SHA
    209ed1a View commit details
    Browse the repository at this point in the history

  6. apollo-server-core: remove workaround for a noUnusedLocals bug 

    Technically this is not a no-op if you have `this.requestOptions.parseOptions`,
but the parseOptions line wasn't there at all when this workaround was
originally added in #1126

(I don't remember exactly what was going on here but I assume it was "doesn't
compile without these extra lines".)
    @glasser
    glasser committed May 5, 2021
    Configuration menu
    Copy the full SHA
    9ba0df6 View commit details
    Browse the repository at this point in the history