Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hexagon] Add schedule and test for conv2d_transpose_nchw #11175

Merged
merged 8 commits into from
May 3, 2022
Merged

[Hexagon] Add schedule and test for conv2d_transpose_nchw #11175

merged 8 commits into from
May 3, 2022

Conversation

farshidsp
Copy link
Contributor

This PR adds conv2d_transpose schedule and test on hexagon target. This is needed for Pynet model.
cc @mehrdadh @csullivan

@github-actions github-actions bot requested review from csullivan and mehrdadh April 29, 2022 01:17
Copy link
Member

@mehrdadh mehrdadh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. It needs couple of small changes.
Also, I think you need to register the schedule for hexagon strategy.

tvm.testing.assert_allclose(c.numpy(), c_np, rtol=1e-5)


class TestConv2DTranspose_1(BaseConv2DTransposeTests):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you combine these three classes using this patter:
batch, in_channel, ... = tvm.testing.parameters((1, (3, 8), ...)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also rename the class to TestConv2DTranspose

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion. Have addressed both in the next commit.

Copy link
Member

@mehrdadh mehrdadh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks!

Copy link
Contributor

@csullivan csullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! :shipit:

@csullivan csullivan merged commit eb3ce91 into apache:main May 3, 2022
@csullivan
Copy link
Contributor

Thanks @farshidsp @mehrdadh, this is merged!

shtinsa pushed a commit to Deelvin/tvm that referenced this pull request May 17, 2022
* Add test for registered scheduales - depthwise_conv2d

* added more test to depthwise_conv2

* adding new line at the end of the file

* reformatted the file

* resolve comments

* add schedule and tests for conv2d_transpose_nchw

* registering conv2d_transpose strategy and clean up test
SebastianBoblest pushed a commit to SebastianBoblest/tvm that referenced this pull request May 27, 2022
* Add test for registered scheduales - depthwise_conv2d

* added more test to depthwise_conv2

* adding new line at the end of the file

* reformatted the file

* resolve comments

* add schedule and tests for conv2d_transpose_nchw

* registering conv2d_transpose strategy and clean up test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants