-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hexagon] Add schedule and test for conv2d_transpose_nchw #11175
[Hexagon] Add schedule and test for conv2d_transpose_nchw #11175
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. It needs couple of small changes.
Also, I think you need to register the schedule for hexagon strategy.
tvm.testing.assert_allclose(c.numpy(), c_np, rtol=1e-5) | ||
|
||
|
||
class TestConv2DTranspose_1(BaseConv2DTransposeTests): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you combine these three classes using this patter:
batch, in_channel, ... = tvm.testing.parameters((1, (3, 8), ...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also rename the class to TestConv2DTranspose
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion. Have addressed both in the next commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Thanks @farshidsp @mehrdadh, this is merged! |
* Add test for registered scheduales - depthwise_conv2d * added more test to depthwise_conv2 * adding new line at the end of the file * reformatted the file * resolve comments * add schedule and tests for conv2d_transpose_nchw * registering conv2d_transpose strategy and clean up test
* Add test for registered scheduales - depthwise_conv2d * added more test to depthwise_conv2 * adding new line at the end of the file * reformatted the file * resolve comments * add schedule and tests for conv2d_transpose_nchw * registering conv2d_transpose strategy and clean up test
This PR adds conv2d_transpose schedule and test on hexagon target. This is needed for Pynet model.
cc @mehrdadh @csullivan