fix(explore): chart link is broken without localStorage #21707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktmud
approved these changes
Oct 5, 2022
ktmud
reviewed
Oct 5, 2022
| result.form_data, | ||
| dashboardContextFormData, | ||
| ) | ||
| : result.form_data; |
There was a problem hiding this comment.
Could this be merged into getFormDataWithDashboardContext? Basically make the second parameter nullable?
There was a problem hiding this comment.
I'd rather to keep this way because using getFormDataWithDashboardContext without dashboardContent seems odd.
Codecov Report
@@ Coverage Diff @@
## master #21707 +/- ##
=======================================
Coverage 66.85% 66.85%
=======================================
Files 1799 1799
Lines 68875 68875
Branches 7319 7320 +1
=======================================
Hits 46044 46044
Misses 20944 20944
Partials 1887 1887
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Addition to #21422 issue
"Edit chart" from dashboard may not work if the dashboard context is not found in localStorage.
It's specially missing
filterBoxmetadata due to the lack of exploreFormData mapping in mergeFilterBoxToFormData.This could happen when users either don't have localStorage enabled in there browser (unlikely) or copied the link in the different browser.
This commit fixes this issue by using the original explore formData if dashboardContextFormData is empty.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
cc: @ktmud