fix(explore): chart link is broken without localStorage (#21707)

apache · Oct 7, 2022 · 35d9cb3 · 35d9cb3
1 parent 200bed6
commit 35d9cb3
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/superset-frontend/src/explore/ExplorePage.tsx b/superset-frontend/src/explore/ExplorePage.tsx
@@ -101,7 +101,7 @@ const getDashboardContextFormData = () => {
     Object.assign(dashboardContextWithFilters, { dashboardId });
     return dashboardContextWithFilters;
   }
-  return {};
+  return null;
 };
 
 export default function ExplorePage() {
@@ -117,10 +117,12 @@ export default function ExplorePage() {
     if (!isExploreInitialized.current || isSaveAction) {
       fetchExploreData(exploreUrlParams)
         .then(({ result }) => {
-          const formData = getFormDataWithDashboardContext(
-            result.form_data,
-            dashboardContextFormData,
-          );
+          const formData = dashboardContextFormData
+            ? getFormDataWithDashboardContext(
+                result.form_data,
+                dashboardContextFormData,
+              )
+            : result.form_data;
           dispatch(
             hydrateExplore({
               ...result,