-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dashboard): JS error when editing charts #21422
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21422 +/- ##
==========================================
- Coverage 66.55% 66.54% -0.01%
==========================================
Files 1791 1791
Lines 68593 68598 +5
Branches 7319 7320 +1
==========================================
Hits 45651 45651
- Misses 21051 21056 +5
Partials 1891 1891
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
/testenv up |
@kgabryje Ephemeral environment spinning up at http://35.88.112.227:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ephemeral environment shutdown and build artifacts deleted. |
(cherry picked from commit 1084bde)
SUMMARY
"Edit chart" from dashboard may throw an JS error if the dashboard context is not found in
localStorage
. This could happen when users either don't havelocalStorage
enabled in there browser (unlikely) or when localStorage has run out of space (for example, ifSQLLAB_BACKEND_PERSISTENCE
isn't enabled in SQL Lab).BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
To reproduce the JS error
Go to a Dashboard page
Delete localStorage item
dashboard__explore_context
:Go edit any chart in the dashboard
ADDITIONAL INFORMATION