-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(alerts/reports): add refresh action #12071
Conversation
909e9b0
to
1e14d9c
Compare
Codecov Report
@@ Coverage Diff @@
## master #12071 +/- ##
==========================================
- Coverage 66.62% 63.37% -3.25%
==========================================
Files 962 963 +1
Lines 47368 47385 +17
Branches 4629 4631 +2
==========================================
- Hits 31557 30030 -1527
- Misses 15684 17171 +1487
- Partials 127 184 +57
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
1e14d9c
to
2fb9337
Compare
superset-frontend/src/components/LastUpdated/LastUpdated.test.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and thanks for the quick inquiry responses. Thanks for the folderized component too! Not sure if a Storybook entry is really needed, but maybe some rainy day we can sweep through and add them for all components.
@rusackas thanks for the review! I just updated the typing to use |
757009b
to
c139908
Compare
* upstream/master: (55 commits) feat(explore): time picker enhancement (apache#11418) feat: update alert/report icons and column order (apache#12081) feat(explore): metrics and filters controls redesign (apache#12095) feat(alerts/reports): add refresh action (apache#12071) chore: add latest tag action (apache#11148) fix(reports): increase crontab size and alert fixes (apache#12056) Small typo fix in Athena connection docs (apache#12099) feat(queries): security perm simplification (apache#12072) feat(databases): security perm simplification (apache#12036) feat(dashboards): security permissions simplification (apache#12012) feat(logs): security permissions simplification (apache#12061) chore: Remove unused CodeModal (apache#11972) Fix typescript error (apache#12074) fix: handle context-dependent feature flags in CLI (apache#12088) fix: Fix "View in SQLLab" bug (apache#12086) feat(alert/report): add 'not null' condition option to modal (apache#12077) bumping superset ui to 15.18 and deckgl to 0.3.2 (apache#12078) fix: Python dependencies in apache#11499 (apache#12079) reset active tab on open (apache#12048) fix: improve import flow UI/UX (apache#12070) ...
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
TEST PLAN
ADDITIONAL INFORMATION