fix: improve import flow UI/UX #12070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12070 +/- ##
==========================================
- Coverage 66.57% 60.20% -6.38%
==========================================
Files 956 914 -42
Lines 46859 45148 -1711
Branches 4590 4079 -511
==========================================
- Hits 31198 27180 -4018
- Misses 15535 17968 +2433
+ Partials 126 0 -126
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
eschutho
reviewed
Dec 16, 2020
| import { useImportResource } from 'src/views/CRUD/hooks'; | ||
| import { ImportResourceName } from 'src/views/CRUD/types'; | ||
|
|
||
| export const StyledIcon = styled(Icon)` | ||
| margin: auto ${({ theme }) => theme.gridUnit * 2}px auto 0; | ||
| `; | ||
|
|
||
| const HelperMessage = styled.div` | ||
| display: block; |
There was a problem hiding this comment.
curious, is there something that is inherited that is making this div some other kind of display, since block is the default?
There was a problem hiding this comment.
Ah, you're right, it's not needed here. I copied the style from another helper class where the display is flex.
eschutho
approved these changes
Dec 16, 2020
amitmiran137
pushed a commit
to simcha90/incubator-superset
that referenced
this pull request
Dec 18, 2020
* upstream/master: (55 commits) feat(explore): time picker enhancement (apache#11418) feat: update alert/report icons and column order (apache#12081) feat(explore): metrics and filters controls redesign (apache#12095) feat(alerts/reports): add refresh action (apache#12071) chore: add latest tag action (apache#11148) fix(reports): increase crontab size and alert fixes (apache#12056) Small typo fix in Athena connection docs (apache#12099) feat(queries): security perm simplification (apache#12072) feat(databases): security perm simplification (apache#12036) feat(dashboards): security permissions simplification (apache#12012) feat(logs): security permissions simplification (apache#12061) chore: Remove unused CodeModal (apache#11972) Fix typescript error (apache#12074) fix: handle context-dependent feature flags in CLI (apache#12088) fix: Fix "View in SQLLab" bug (apache#12086) feat(alert/report): add 'not null' condition option to modal (apache#12077) bumping superset ui to 15.18 and deckgl to 0.3.2 (apache#12078) fix: Python dependencies in apache#11499 (apache#12079) reset active tab on open (apache#12048) fix: improve import flow UI/UX (apache#12070) ...
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Improve the UI/UX in the import modal:
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Updated import icon (top-right):
Updated modal:
Asking for password:
Modal is cleared after import:
Asking for overwrite confirmation:
TEST PLAN
See screenshots.
ADDITIONAL INFORMATION