chore: add latest tag action #11148

eschutho · 2020-10-03T00:26:45Z

SUMMARY

Action that adds a "latest" tag to release. It also overwrites/removes the last "latest" tag.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

dpgaspar

Cool automation! maybe drop a comment that this will automatically run on https://github.com/apache/incubator-superset/blob/master/RELEASING/README.md and a different one superset docs/instalation

eschutho · 2020-10-06T23:45:09Z

Cool automation! maybe drop a comment that this will automatically run on https://github.com/apache/incubator-superset/blob/master/RELEASING/README.md and a different one superset docs/instalation

good idea. I had an earlier PR with docs/instructions to check out the latest before this tag that was blocked, so I just included it in here.

codecov-io · 2020-10-07T00:06:18Z

Codecov Report

Merging #11148 (b6a7ef1) into master (e0288bf) will decrease coverage by 12.79%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #11148       +/-   ##
===========================================
- Coverage   67.68%   54.89%   -12.80%     
===========================================
  Files         930      421      -509     
  Lines       45132    14810    -30322     
  Branches     4331     3821      -510     
===========================================
- Hits        30549     8130    -22419     
+ Misses      14480     6680     -7800     
+ Partials      103        0      -103

Flag	Coverage Δ
cypress	`54.89% <ø> (ø)`
javascript	`?`
python	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...uperset-frontend/src/dashboard/util/dnd-reorder.js	`0.00% <0.00%> (-100.00%)`	⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js	`0.00% <0.00%> (-100.00%)`	⬇️
...dashboard/components/resizable/ResizableHandle.jsx	`0.00% <0.00%> (-100.00%)`	⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js	`0.00% <0.00%> (-93.48%)`	⬇️
...src/dashboard/components/gridComponents/Header.jsx	`10.52% <0.00%> (-86.85%)`	⬇️
...rc/dashboard/components/gridComponents/Divider.jsx	`13.33% <0.00%> (-86.67%)`	⬇️
...ontend/src/dashboard/util/getDashboardFilterKey.ts	`14.28% <0.00%> (-85.72%)`	⬇️
...nd/src/views/CRUD/data/query/QueryPreviewModal.tsx	`14.70% <0.00%> (-82.97%)`	⬇️
...set-frontend/src/views/CRUD/welcome/EmptyState.tsx	`5.71% <0.00%> (-82.10%)`	⬇️
...et-frontend/src/SqlLab/components/TableElement.jsx	`4.70% <0.00%> (-81.35%)`	⬇️
... and 777 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0288bf...b6a7ef1. Read the comment docs.

villebro

LGTM. My only worry is the scenario where we might do a fix to an old version (say 0.37.3) after we've released a more recent major/minor 0.38.0. In that case I believe this would point latest to 0.37.3. I think this won't be a problem right now, but once we hit 1.0, we'll probably start having this problem when we start releasing new majors while maintaining minors for stability.

docs/src/pages/docs/installation/installing_scratch.mdx

eschutho · 2020-10-08T01:30:17Z

LGTM. My only worry is the scenario where we might do a fix to an old version (say 0.37.3) after we've released a more recent major/minor 0.38.0. In that case I believe this would point latest to 0.37.3. I think this won't be a problem right now, but once we hit 1.0, we'll probably start having this problem when we start releasing new majors while maintaining minors for stability.

That's a good point. Let me see if there's a check I can do in this action to make this more accurate.

eschutho · 2020-10-10T00:24:43Z

@villebro I updated the logic in the action to see if the new release is tagged with a later version, if you want to take another look. thanks!

villebro

A few comments. I wonder if this could be changed into a bash script that could also be run from the command for testing? There's lots of really helpful echos here that could be helpful when run locally when further developing this functionality.

villebro · 2020-10-12T06:49:15Z

.github/workflows/latest-release-tag.yml

+    - name: Check for latest tag
+      id: latest-tag
+      run: |
+        LATEST_TAG=$(git show-ref --tags -d | grep latest^{} | sed 's/refs\/tags\/latest^{}//') || echo 'not found'


It took me some time to figure out what ^{} means in this context (I thought it was some non-standard regex in grep 😆 ). Perhaps we could add a comment here explaining what we're greping and seding.

I wound up changing the lookup on this, so that we didn't have to look for the tag with the pointer sha. It should read a bit better now.

villebro · 2020-10-12T06:53:44Z

.github/workflows/latest-release-tag.yml

+            LATEST_RC_TAG_SPLIT=(${LATEST_RC_TAG})
+
+            ## remove the 'rc' from the current tag if it exists and split into an array at the dot
+            THIS_TAG=($(echo ${{ github.event.release.tag_name }} | sed 's/rc//'))  || echo 'not found'


We probably don't want to consider release candidates for latest?

thanks.. I removed them.

eschutho · 2020-12-04T01:10:33Z

@villebro this should be ready for another look. I pulled the script out of the github action, so it can be run separate, with or without a --dry-run flag. You can also use a tool like nektos/act to run the github action directly. I could potentially add info into the readme on that, or we can leave as is. Either way, lmk what you think, especially if you get a chance to test this out!

eschutho · 2020-12-04T17:59:34Z

Found one more bug I want to test...

eschutho · 2020-12-11T00:25:46Z

I tested a few more times, and it's looking stable so far. Maybe we should consider some bash automated testing systems?

eschutho · 2020-12-11T00:36:38Z

.github/workflows/latest-release-tag.yml

+        description: Superset latest release
+        tag-name: latest
+      env:
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}


@ktmud may have some insight on using secrets.GITHUB_TOKEN vs github.GITHUB_TOKEN. I haven't seen the latter in documentation, although it seems that using it over the secrets could be worth looking at.

It seems there is no github.GITHUB_TOKEN available according to the doc, but github.token is equivalent to secrets.GITHUB_TOKEN: https://docs.github.com/en/free-pro-team@latest/actions/reference/context-and-expression-syntax-for-github-actions#github-context

great. thanks for that. That makes sense.

villebro

LGTM!

eschutho · 2020-12-14T18:26:01Z

@villebro I caught another small bug during demo. I'll put up a fix today.

eschutho · 2020-12-14T18:48:19Z

Ok, just one more small change ba31898 It shouldn't affect the rest of the functionality, it's just one more check to be sure that the tag passed in exists. It won't be an issue when using the action itself, but could happen when someone uses the script directly.

eschutho · 2020-12-15T18:26:38Z

@villebro @dpgaspar I think this is ready on my end. If everything looks good to you, you can merge when ready. Thanks for all your help!

eschutho · 2020-12-17T18:27:10Z

When we land this, we should create a latest tag on 0.38.0.

* upstream/master: (55 commits) feat(explore): time picker enhancement (apache#11418) feat: update alert/report icons and column order (apache#12081) feat(explore): metrics and filters controls redesign (apache#12095) feat(alerts/reports): add refresh action (apache#12071) chore: add latest tag action (apache#11148) fix(reports): increase crontab size and alert fixes (apache#12056) Small typo fix in Athena connection docs (apache#12099) feat(queries): security perm simplification (apache#12072) feat(databases): security perm simplification (apache#12036) feat(dashboards): security permissions simplification (apache#12012) feat(logs): security permissions simplification (apache#12061) chore: Remove unused CodeModal (apache#11972) Fix typescript error (apache#12074) fix: handle context-dependent feature flags in CLI (apache#12088) fix: Fix "View in SQLLab" bug (apache#12086) feat(alert/report): add 'not null' condition option to modal (apache#12077) bumping superset ui to 15.18 and deckgl to 0.3.2 (apache#12078) fix: Python dependencies in apache#11499 (apache#12079) reset active tab on open (apache#12048) fix: improve import flow UI/UX (apache#12070) ...

superset-github-bot bot added the preset-io label Oct 3, 2020

pull-request-size bot added the size/S label Oct 3, 2020

eschutho changed the title ~~add latest tag action~~ [WIP] chore: add latest tag action Oct 3, 2020

eschutho marked this pull request as draft October 3, 2020 00:31

eschutho force-pushed the elizabeth/latest-tag-action branch from 36d82b2 to dba1cd6 Compare October 3, 2020 00:34

eschutho changed the title ~~[WIP] chore: add latest tag action~~ chore: add latest tag action Oct 3, 2020

eschutho marked this pull request as ready for review October 3, 2020 00:37

eschutho force-pushed the elizabeth/latest-tag-action branch from dba1cd6 to 8dcf2da Compare October 5, 2020 16:39

willbarrett requested review from dpgaspar and villebro October 5, 2020 22:26

dpgaspar reviewed Oct 6, 2020

View reviewed changes

eschutho force-pushed the elizabeth/latest-tag-action branch from cc1011e to b87b162 Compare October 6, 2020 23:43

pull-request-size bot added size/M and removed size/S labels Oct 6, 2020

eschutho mentioned this pull request Oct 6, 2020

docs: add checkout tagged release instructions to docs #11122

Closed

6 tasks

villebro approved these changes Oct 7, 2020

View reviewed changes

docs/src/pages/docs/installation/installing_scratch.mdx Outdated Show resolved Hide resolved

eschutho force-pushed the elizabeth/latest-tag-action branch from 8d8d5e0 to 0f1ab3f Compare October 7, 2020 23:43

eschutho marked this pull request as draft October 8, 2020 01:30

pull-request-size bot added size/L and removed size/M labels Oct 9, 2020

eschutho force-pushed the elizabeth/latest-tag-action branch from 80ee970 to 1bd4b69 Compare October 9, 2020 23:56

eschutho marked this pull request as ready for review October 9, 2020 23:57

eschutho force-pushed the elizabeth/latest-tag-action branch 2 times, most recently from 7101943 to ceb8e43 Compare October 10, 2020 00:16

eschutho requested a review from villebro October 10, 2020 00:23

villebro reviewed Oct 12, 2020

View reviewed changes

eschutho force-pushed the elizabeth/latest-tag-action branch from 4d423dc to b6a7ef1 Compare December 4, 2020 00:34

eschutho marked this pull request as ready for review December 4, 2020 00:35

eschutho added 5 commits December 3, 2020 17:00

add latest tag action

90a937e

update documentation with latest tag info

b423f5d

Python in docs doesn't need v3 reference

d1130d8

add check that latest tag is truly a later version

973d47a

remove rc from acceptable tags

589c4ef

eschutho force-pushed the elizabeth/latest-tag-action branch from b6a7ef1 to 589c4ef Compare December 4, 2020 01:05

eschutho marked this pull request as draft December 4, 2020 17:59

move tag script to seperate file

db2b28c

eschutho force-pushed the elizabeth/latest-tag-action branch from 8a0dbb5 to db2b28c Compare December 11, 2020 00:22

eschutho marked this pull request as ready for review December 11, 2020 00:23

eschutho requested a review from villebro December 11, 2020 00:24

eschutho commented Dec 11, 2020

View reviewed changes

villebro approved these changes Dec 11, 2020

View reviewed changes

eschutho marked this pull request as draft December 14, 2020 18:26

add a check that the tag exists

ba31898

eschutho marked this pull request as ready for review December 14, 2020 18:46

villebro merged commit 895fa19 into apache:master Dec 17, 2020

villebro deleted the elizabeth/latest-tag-action branch December 17, 2020 18:52

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: add latest tag action #11148

chore: add latest tag action #11148

eschutho commented Oct 3, 2020

dpgaspar left a comment •

edited

Loading

eschutho commented Oct 6, 2020

codecov-io commented Oct 7, 2020 •

edited

Loading

villebro left a comment

eschutho commented Oct 8, 2020

eschutho commented Oct 10, 2020

villebro left a comment

villebro Oct 12, 2020

eschutho Dec 4, 2020

villebro Oct 12, 2020

eschutho Dec 4, 2020

eschutho commented Dec 4, 2020

eschutho commented Dec 4, 2020

eschutho commented Dec 11, 2020

eschutho Dec 11, 2020

ktmud Dec 11, 2020 •

edited

Loading

eschutho Dec 14, 2020

villebro left a comment

eschutho commented Dec 14, 2020

eschutho commented Dec 14, 2020

eschutho commented Dec 15, 2020

eschutho commented Dec 17, 2020

chore: add latest tag action #11148

chore: add latest tag action #11148

Conversation

eschutho commented Oct 3, 2020

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

dpgaspar left a comment • edited Loading

Choose a reason for hiding this comment

eschutho commented Oct 6, 2020

codecov-io commented Oct 7, 2020 • edited Loading

Codecov Report

villebro left a comment

Choose a reason for hiding this comment

eschutho commented Oct 8, 2020

eschutho commented Oct 10, 2020

villebro left a comment

Choose a reason for hiding this comment

villebro Oct 12, 2020

Choose a reason for hiding this comment

eschutho Dec 4, 2020

Choose a reason for hiding this comment

villebro Oct 12, 2020

Choose a reason for hiding this comment

eschutho Dec 4, 2020

Choose a reason for hiding this comment

eschutho commented Dec 4, 2020

eschutho commented Dec 4, 2020

eschutho commented Dec 11, 2020

eschutho Dec 11, 2020

Choose a reason for hiding this comment

ktmud Dec 11, 2020 • edited Loading

Choose a reason for hiding this comment

eschutho Dec 14, 2020

Choose a reason for hiding this comment

villebro left a comment

Choose a reason for hiding this comment

eschutho commented Dec 14, 2020

eschutho commented Dec 14, 2020

eschutho commented Dec 15, 2020

eschutho commented Dec 17, 2020

dpgaspar left a comment •

edited

Loading

codecov-io commented Oct 7, 2020 •

edited

Loading

ktmud Dec 11, 2020 •

edited

Loading