[SPARK-22857] Optimize code by inspecting code #20044
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
In the past we've said 'no' to random small changes to the code like this. Some changes like _ to null probably aren't worth it at all. (0) to .head is the same, I think. Removing unused imports is OK, and I personally am OK with .size to .length for arrays because it avoids an implicit conversion. But, it needs to be done consistently or not at all. |
Optimize code by inspecting code, including: remove some unused import change invoking array size method to length method
|
Ok, I remove some changes. |
srowen
reviewed
Dec 21, 2017
|
@srowen I find all related array size warning, are there any other issues? |
|
There are lots more than this, no. I don't think it's worthwhile, unless you're finding several that might cause a performance problem. |
srowen
added a commit
to srowen/spark
that referenced
this pull request
Dec 31, 2017
Closes apache#18916 Closes apache#19613 Closes apache#19739 Closes apache#19936 Closes apache#19919 Closes apache#19933 Closes apache#19917 Closes apache#20027 Closes apache#19035 Closes apache#20044 Closes apache#20104
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize code by inspecting code, including:
remove some unused import
change invoking array size method to length method
use head method
What changes were proposed in this pull request?
Optimize code by inspecting code
How was this patch tested?
No