[SPARK-22725][SQL] Add failing test for select with a splatted stream #19917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ash211
changed the title
|
Test build #84590 has finished for PR 19917 at commit
|
|
Test build #84592 has finished for PR 19917 at commit
|
|
This test fails. You identified a change that'll fix it already, so, why not add that here? no need for more JIRAs. That said I'm not clear if this isn't simply resolved in your app by not using Stream. |
|
Let's close this or make it actually fix the issue. |
srowen
added a commit
to srowen/spark
that referenced
this pull request
Dec 31, 2017
Closes apache#18916 Closes apache#19613 Closes apache#19739 Closes apache#19936 Closes apache#19919 Closes apache#19933 Closes apache#19917 Closes apache#20027 Closes apache#19035 Closes apache#20044 Closes apache#20104
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add additional test. I plan to file an issue in SPARK Jira soon detailing this change. It seems like there is an assumption in
.selectabout some behavior that's not guaranteed bySeqbut does exist in aList, because replacingStreamwithSeqin the test causes it to pass. Possibly this is due to Seq#map being lazy whereas List#map is eager.How was this patch tested?
Additional test.