[SPARK-21822][SQL]When insert Hive Table is finished, it is better to clean out the tmpLocation dir #19035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
figo77
changed the title
figo77
changed the title
|
I think this change is very useful, auto-delete tmp location dir like : .hive-staging_xxxxxx could make everyone only see the target table's partition dir. |
|
Can one of the admins verify this patch? |
gaborgsomogyi
requested changes
Dec 20, 2017
| @@ -435,6 +435,18 @@ case class InsertIntoHiveTable( | |||
| logWarning(s"Unable to delete staging directory: $stagingDir.\n" + e) | |||
| } | |||
|
|
|||
| //delete the tmpLocation dir | |||
There was a problem hiding this comment.
lint-scala gives error for this line: Insert a space after the start of the comment.
| } | ||
| } catch { | ||
| case NonFatal(e) => | ||
| logWarning(s"Unable to delete tmpLocation directory:" + tmpLocation.toString + "\n" + e) |
There was a problem hiding this comment.
This can be compressed a bit:
logWarning(s"Unable to delete tmpLocation directory: $tmpLocation\n$e")
|
I think the problem is gone, right? Could you see the latest file version: |
|
@figo77 Could you close it? |
srowen
added a commit
to srowen/spark
that referenced
this pull request
Dec 31, 2017
Closes apache#18916 Closes apache#19613 Closes apache#19739 Closes apache#19936 Closes apache#19919 Closes apache#19933 Closes apache#19917 Closes apache#20027 Closes apache#19035 Closes apache#20044 Closes apache#20104
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When insert Hive Table is finished, it is better to clean out the tmpLocation dir(the temp directories like ".hive-staging_hive_2017-08-19_10-56-01_540_5448395226195533570-9/-ext-10000" or "/tmp/hive/..." for an old spark version).
Otherwise, when lots of spark job are executed, millions of temporary directories are left in HDFS. And these temporary directories can only be deleted by the maintainer through the shell script.
How was this patch tested?