Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Close stale PRs #18223

Closed
wants to merge 1 commit into from
Closed

Conversation

HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Jun 7, 2017

What changes were proposed in this pull request?

This PR proposes to close stale PRs, mostly the same instances with #18017

Closes #11459
Closes #13833
Closes #13720
Closes #12506
Closes #12456
Closes #12252
Closes #17689
Closes #17791
Closes #18163
Closes #17640
Closes #17926
Closes #18163
Closes #12506
Closes #18044
Closes #14036
Closes #15831
Closes #14461
Closes #17638
Closes #18222

Added:
Closes #18045
Closes #18061
Closes #18010
Closes #18041
Closes #18124
Closes #18130
Closes #12217

Added:
Closes #16291
Closes #17480
Closes #14995

Added:
Closes #12835
Closes #17141

How was this patch tested?

N/A

@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented Jun 7, 2017

Please let me know if any author is active on any PR. Let me take them out. I picked up inclusively.

@HyukjinKwon
Copy link
Member Author

cc @vanzin and @srowen.

@SparkQA
Copy link

SparkQA commented Jun 7, 2017

Test build #77791 has finished for PR 18223 at commit 6836bee.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member

cc @jiangxb1987 Could you take a look at the list too?

@srowen
Copy link
Member

srowen commented Jun 7, 2017

Add to the list:

#18045
#18061
#18010
#18041
#18124
#18130
#12217

@vanzin
Copy link
Contributor

vanzin commented Jun 7, 2017

Add:
#16291
#17480
#14995

@jiangxb1987
Copy link
Contributor

Add:
#12835
#17141
#18044
#18130

@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented Jun 7, 2017

#18130 and #18044 are duplicates. I added the others assuming (and it looks to me) they are inactive, reviewed or the JIRA is already resolved.

@jiangxb1987
Copy link
Contributor

@HyukjinKwon How about keep #17716 open? I think we still need this and Herman will continue working on this.

@HyukjinKwon
Copy link
Member Author

Sure.

@HyukjinKwon
Copy link
Member Author

I took out 17645 per #17645 (comment)

@HyukjinKwon
Copy link
Member Author

Took out 15326 per #15326 (comment)

@srowen
Copy link
Member

srowen commented Jun 8, 2017

I'll merge this. If anything got closed that anyone disagrees with, it can easily be reopened, so there is virtually no harm in a false-positive anyway. But looks like the list has been reasonably reviewed.

@asfgit asfgit closed this in b771fed Jun 8, 2017
@HyukjinKwon HyukjinKwon deleted the close-stale-prs branch January 2, 2018 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants