[SPARK-19952][SQL] Remove various analysis exceptions #17716
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvanhovell
commented
Apr 21, 2017
| case _: NoSuchTableException => | ||
| u.failAnalysis(s"Table or view not found: ${tableIdentWithDb.unquotedString}") | ||
| // If the database is defined and that database is not found, throw an AnalysisException. | ||
| if (!tableIdentWithDb.database.exists(catalog.databaseExists)) { |
There was a problem hiding this comment.
Perhaps we should move this into catalog.lookupRelation and attach the location here.
There was a problem hiding this comment.
how about
try {
catalog.lookupRelation(tableIdentWithDb)
} catch {
case a: AnalysisException => u.failAnalysis(a.message)
}
There was a problem hiding this comment.
Yeah, could work. This change is also causing the tests to fail, so I am revisiting it.
|
Test build #76031 has finished for PR 17716 at commit
|
|
Test build #76039 has finished for PR 17716 at commit
|
gatorsmile
reviewed
Apr 22, 2017
| @@ -160,7 +159,7 @@ abstract class SQLViewSuite extends QueryTest with SQLTestUtils { | |||
| } | |||
|
|
|||
| private def assertNoSuchTable(query: String): Unit = { | |||
| intercept[NoSuchTableException] { | |||
| intercept[AnalysisException] { | |||
There was a problem hiding this comment.
AnalysisException is a pretty general Exception in Spark SQL. The future refactoring might introduce bugs without trigger any test case failure.
Could we check the error messages?
|
@hvanhovell, how is it going? |
|
ping @hvanhovell Are you still working on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We currently have quite a few analysis exception subclasses, the problem with these is that they are not well supported throughout Spark (in pySpark for example) and that the added value is limited. This PR removes the
no such objectand thealready existsexceptions, and replaces them by a factory methods that create analysis exceptions with the required error messages.How was this patch tested?
Modified existing tests.