Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Close stale PRs #18417

Closed
wants to merge 1 commit into from
Closed

Conversation

HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Jun 25, 2017

What changes were proposed in this pull request?

This PR proposes to close stale PRs, mostly the same instances with #18017

I believe the author in #14807 removed his account.

Closes #7075
Closes #8927
Closes #9202
Closes #9366
Closes #10861
Closes #11420
Closes #12356
Closes #13028
Closes #13506
Closes #14191
Closes #14198
Closes #14330
Closes #14807
Closes #15839
Closes #16225
Closes #16685
Closes #16692
Closes #16995
Closes #17181
Closes #17211
Closes #17235
Closes #17237
Closes #17248
Closes #17341
Closes #17708
Closes #17716
Closes #17721
Closes #17937

Added:
Closes #14739
Closes #17139
Closes #17445
Closes #18042
Closes #18359

Added:
Closes #16450
Closes #16525
Closes #17738

Added:
Closes #16458
Closes #16508
Closes #17714

Added:
Closes #17830
Closes #14742

How was this patch tested?

N/A

@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented Jun 25, 2017

Please let me know if any author is active on any PR. Let me take them out. I picked up inclusively. My point here is to close PRs inactive to review comments and only leave PRs that wait for a review. Leave any comment if it is in a progress in any way. If missed, I guess picking up the commits and opening new one would be welcome in many cases (I guess the author can't reopen if it is closed by ASF account but I think it does not mean not to propose the change again).

@HyukjinKwon
Copy link
Member Author

cc @srowen, @vanzin, @gatorsmile and @jiangxb1987 who I believe are interested in this PR. Could you take a look please?

@SparkQA
Copy link

SparkQA commented Jun 25, 2017

Test build #78580 has finished for PR 18417 at commit 6cdf056.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Jun 25, 2017

Suggest adding:
#14739
#17139
#17445
#18042
#18359

@jiangxb1987
Copy link
Contributor

Let's keep the following PRs open, because I believe they're good to have and the authors will soon be responding:
#15405
#17401
#17716

Also, I'd suggest we add the following PRs to the list:
#16450
#16525
#17738

Thanks!

@HyukjinKwon
Copy link
Member Author

I added all suggested one and took out 15405 and 17401 per requested. I guess the author should be responsive and I took out 17716 before. I think it is unfair to take out this again.

@imatiach-msft
Copy link
Contributor

imatiach-msft commented Jun 26, 2017

can you please keep 17084 open? thanks!

@HyukjinKwon
Copy link
Member Author

Sure.

@jiangxb1987
Copy link
Contributor

Please add the following:
#16458
#16508
#17714

Thanks!

@HyukjinKwon
Copy link
Member Author

Added.

@HyukjinKwon
Copy link
Member Author

14957 was taken out as closed.

@gatorsmile
Copy link
Member

Three more PRs?
#17830
#14742
#17211

@HyukjinKwon
Copy link
Member Author

Sure.

@HyukjinKwon
Copy link
Member Author

(17211 is a dupe)

@HyukjinKwon
Copy link
Member Author

12257 was taken out as closed.

@ScrapCodes
Copy link
Member

15258 can also be taken out

@HyukjinKwon
Copy link
Member Author

Sure, I did.

@srowen
Copy link
Member

srowen commented Jun 27, 2017

Merged this pass to master

@asfgit asfgit closed this in b32bd00 Jun 27, 2017
@HyukjinKwon HyukjinKwon deleted the close-stale-pr branch January 2, 2018 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants