[SPARK-16124][SQL] fix getHiveFile return file url in jar that cannot be load in SQL
#13833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
gatorsmile
reviewed
May 23, 2017
| @@ -180,7 +181,12 @@ private[hive] class TestHiveSparkSession( | |||
| ShutdownHookManager.registerShutdownDeleteDir(hiveFilesTemp) | |||
|
|
|||
| def getHiveFile(path: String): File = { | |||
There was a problem hiding this comment.
TestHive is only used for our unit testing.
|
Thanks for working on it. This does not sound an issue to Spark SQL users. Cloud we close this PR now? |
|
+1 for closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
I create a temp file from output stream of the file in jar and return that file
How was this patch tested?
manual tests