Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit test cases #5459

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Fix unit test cases #5459

merged 1 commit into from
Feb 5, 2024

Conversation

style95
Copy link
Member

@style95 style95 commented Feb 2, 2024

Description

This regression is introduced by merging b9f16dc

It seems the PR had passed all checks and was somewhat outdated after that.
So it was seemingly pass all checks but actually not.

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6d99fd1) 58.31% compared to head (0ffed60) 76.59%.

❗ Current head 0ffed60 differs from pull request most recent head e6309b3. Consider uploading reports for the commit e6309b3 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5459       +/-   ##
===========================================
+ Coverage   58.31%   76.59%   +18.28%     
===========================================
  Files         241      241               
  Lines       14649    14649               
  Branches      629      629               
===========================================
+ Hits         8542    11220     +2678     
+ Misses       6107     3429     -2678     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ningyougang
Copy link
Contributor

LGTM

@style95
Copy link
Member Author

style95 commented Feb 5, 2024

@ningyougang Thanks

@style95 style95 merged commit 4b5c5d1 into apache:master Feb 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants