Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the required_status_checks to strict #5460

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

style95
Copy link
Member

@style95 style95 commented Feb 3, 2024

Description

Change the required_status_checks to strict in the branch protection rule.
It has pros and cons because it would require all PRs to be updated before merging.
But it could prevent issues like this.

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3f11fcc) 4.52% compared to head (92f2f14) 76.40%.
Report is 1 commits behind head on master.

❗ Current head 92f2f14 differs from pull request most recent head 7a1a08a. Consider uploading reports for the commit 7a1a08a to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5460       +/-   ##
===========================================
+ Coverage    4.52%   76.40%   +71.88%     
===========================================
  Files         241      241               
  Lines       14649    14649               
  Branches      629      629               
===========================================
+ Hits          663    11193    +10530     
+ Misses      13986     3456    -10530     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@style95
Copy link
Member Author

style95 commented Feb 3, 2024

#5459 this needs to be merged first.

Copy link
Member

@dgrove-oss dgrove-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably the right tradeoff overall.

@style95 style95 merged commit e20ab17 into apache:master Feb 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants