Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep GitHub Actions up to date with GitHub's Dependabot #5458

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jan 20, 2024

Blocked by #5459
* #5459 (merged)

Create an automatic pull request to upgrade all .github/workflows/XXX.yml files:

-       uses: actions/checkout@v3
+       uses: actions/checkout@v4

https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot

https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#package-ecosystem

Description

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (597d61d) 76.93% compared to head (669d586) 58.33%.
Report is 2 commits behind head on master.

❗ Current head 669d586 differs from pull request most recent head d39e39a. Consider uploading reports for the commit d39e39a to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5458       +/-   ##
===========================================
- Coverage   76.93%   58.33%   -18.60%     
===========================================
  Files         241      241               
  Lines       14647    14647               
  Branches      630      630               
===========================================
- Hits        11268     8544     -2724     
- Misses       3379     6103     +2724     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@style95
Copy link
Member

style95 commented Feb 2, 2024

I didn't dig into it but around 20 unit tests fail in this PR.

@cclauss
Copy link
Contributor Author

cclauss commented Feb 3, 2024

Unit test fail was fixed in

You get the same results fixing a typo…

@cclauss cclauss force-pushed the patch-1 branch 2 times, most recently from 424c4d9 to ba6a686 Compare February 5, 2024 09:56
@cclauss
Copy link
Contributor Author

cclauss commented Feb 5, 2024

Rebased.

@style95 style95 merged commit 5c876f2 into apache:master Feb 5, 2024
6 checks passed
@style95
Copy link
Member

style95 commented Feb 5, 2024

@cclauss Thanks!

@cclauss cclauss deleted the patch-1 branch February 5, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants