Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-477] CI engine test bug fix test #11065

Merged
merged 2 commits into from
Jun 2, 2018
Merged

Conversation

haojin2
Copy link
Contributor

@haojin2 haojin2 commented May 25, 2018

Description

As title

Checklist

Essentials

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Fix for race condition in ThreadedEnginePooled

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@haojin2 haojin2 force-pushed the fix_engine_test branch 10 times, most recently from fb1589d to 48df3a7 Compare May 29, 2018 18:16
@haojin2 haojin2 force-pushed the fix_engine_test branch from 48df3a7 to bdff629 Compare May 31, 2018 23:55
@haojin2 haojin2 changed the title [MXNET-477] [TEST PR] [DO NOT MERGE] [WIP] CI engine test bug fix test [MXNET-477] CI engine test bug fix test Jun 1, 2018
@haojin2 haojin2 force-pushed the fix_engine_test branch from ec6117b to 1f92f1e Compare June 1, 2018 07:00
Copy link
Contributor

@marcoabreu marcoabreu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a specialized test for this please?

@haojin2 haojin2 force-pushed the fix_engine_test branch from 1f92f1e to e319766 Compare June 1, 2018 16:47
Copy link
Contributor

@marcoabreu marcoabreu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a specialized test later

@haojin2
Copy link
Contributor Author

haojin2 commented Jun 2, 2018

@piiswrong @eric-haibin-lin @reminisce Can you guys give a review when you have time? Thanks!

@szha szha merged commit 4554c76 into apache:master Jun 2, 2018
@haojin2 haojin2 deleted the fix_engine_test branch June 2, 2018 05:25
@szha szha mentioned this pull request Jun 12, 2018
@zhreshold zhreshold mentioned this pull request Jun 13, 2018
7 tasks
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
* fix for race condition and try 10000 run on the tests

* getting rid of 10000 repetitive runs after verification
XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018
* fix for race condition and try 10000 run on the tests

* getting rid of 10000 repetitive runs after verification
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants