Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-477] CI engine test bug fix test #11065

Merged
merged 2 commits into from
Jun 2, 2018
Merged

[MXNET-477] CI engine test bug fix test #11065

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdff629
fix for race condition and try 10000 run on the tests
May 31, 2018
e319766
getting rid of 10000 repetitive runs after verification
Jun 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions src/engine/threaded_engine_pooled.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,14 @@ class ThreadedEnginePooled : public ThreadedEngine {
streams_.reset(new StreamManager<kMaxNumGpus, kNumStreamsPerGpu>());
task_queue_.reset(new dmlc::ConcurrentBlockingQueue<OprBlock*>());
io_task_queue_.reset(new dmlc::ConcurrentBlockingQueue<OprBlock*>());
thread_pool_.reset(new ThreadPool(kNumWorkingThreads, [this]() {
ThreadWorker(task_queue_); }));
io_thread_pool_.reset(new ThreadPool(1, [this]() {
ThreadWorker(io_task_queue_); }));
thread_pool_.reset(new ThreadPool(kNumWorkingThreads,
[this](std::shared_ptr<dmlc::ManualEvent> ready_event) {
ThreadWorker(task_queue_, ready_event); },
true));
io_thread_pool_.reset(new ThreadPool(1,
[this](std::shared_ptr<dmlc::ManualEvent> ready_event) {
ThreadWorker(io_task_queue_, ready_event); },
true));
}

protected:
Expand Down Expand Up @@ -113,8 +117,10 @@ class ThreadedEnginePooled : public ThreadedEngine {
*
* The method to pass to thread pool to parallelize.
*/
void ThreadWorker(std::shared_ptr<dmlc::ConcurrentBlockingQueue<OprBlock*>> task_queue) {
void ThreadWorker(std::shared_ptr<dmlc::ConcurrentBlockingQueue<OprBlock*>> task_queue,
const std::shared_ptr<dmlc::ManualEvent>& ready_event) {
OprBlock* opr_block;
ready_event->signal();
while (task_queue->Pop(&opr_block)) {
DoExecute(opr_block);
}
Expand Down