This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Fix engine stop/start #10911
Merged
Fix engine stop/start #10911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoabreu
reviewed
May 12, 2018
| @@ -121,6 +121,19 @@ double EvaluateWorloads(const std::vector<Workload>& workloads, | |||
| return dmlc::GetTime() - t; | |||
| } | |||
|
|
|||
| TEST(Engine, start_stop) { | |||
There was a problem hiding this comment.
Please add documentation
marcoabreu
reviewed
May 12, 2018
|
|
||
| for (int i = 0; i < num_engine; ++i) { | ||
| engine[i]->Stop(); | ||
| engine[i]->Start(); |
There was a problem hiding this comment.
Could you verify whether the actions have actually been successful?
There was a problem hiding this comment.
Without adding new API, I cannot think of a way to verify except sanity test.
marcoabreu
reviewed
May 12, 2018
| @@ -0,0 +1,44 @@ | |||
| # Licensed to the Apache Software Foundation (ASF) under one | |||
There was a problem hiding this comment.
Please don't create a new test directory.
szha
approved these changes
May 15, 2018
|
@piiswrong Can you have a look at the engine part to see if it's correct? |
jinhuang415
pushed a commit
to jinhuang415/incubator-mxnet
that referenced
this pull request
May 29, 2018
* fix engine start/stop * add tests * fix test * fix * fix tests
rahul003
pushed a commit
to rahul003/mxnet
that referenced
this pull request
Jun 4, 2018
* fix engine start/stop * add tests * fix test * fix * fix tests
lebeg
reviewed
Jun 13, 2018
| streams_.reset(new StreamManager<kMaxNumGpus, kNumStreamsPerGpu>()); | ||
| task_queue_.reset(new dmlc::ConcurrentBlockingQueue<OprBlock*>()); | ||
| io_task_queue_.reset(new dmlc::ConcurrentBlockingQueue<OprBlock*>()); | ||
| thread_pool_.reset(new ThreadPool(kNumWorkingThreads, [this]() { |
There was a problem hiding this comment.
Shouldn't this contain change to another constructor of ThreadPool? Only the one accepting std::shared_ptr<dmlc::ManualEvent> ready_event will wait until ready, which might be the issue fixed in #8995.
6 tasks
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
* fix engine start/stop * add tests * fix test * fix * fix tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continued fixes as in #10820.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments