-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-10787: Apply spotless to clients
#16393
Conversation
@gongxuanzhang please rebase code |
@chia7712 complete, thanks your review |
@gongxuanzhang could you add |
@chia7712 I update it. ignore generated code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@chia7712 I'm coming into this late, but please check in the mailing list before doing large reformattings like we are doing here. It causes a bunch of merge conflicts for work in progress, makes cherry-picks for older branches harder and so on. I see the value of the change, but we should seek broader alignment for things that impact many of the developers. |
sorry for large conflicts. We tried to minimize the conflicts by making changes to "imports" only. It seems to me those conflicts are not hard to fix as they are unrelated to "behavior". Also, I have seen many conflicts about the imports before when those import rules are not there. In short, I agree that will cause some panic for a while and I'm sorry, but the benefit is that we can see fewer imports changes caused by each developers' IDE in the future |
Reviewers: Chia-Ping Tsai <[email protected]>
This PR is sub PR from #16097.
It is part of a series of changes to progressively apply [spotless plugin(import-order)] across all modules. In this step, the plugin is activated in the
Module and history
How to test:
We can run
./gradlew spotlessCheck
check for code that does not meet requirements.If we get report that error , we can run
./gradlew spotlessApply
to review my code.In this PR, all change(exclude
build.gradle
)by
spotlessApply`