Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-10787: Apply spotless to connect module #16299

Merged

Conversation

gongxuanzhang
Copy link
Contributor

@gongxuanzhang gongxuanzhang commented Jun 12, 2024

This PR is sub PR from #16097.
It is part of a series of changes to progressively apply [spotless plugin(import-order)] across all modules. In this step, the plugin is activated in the connect exclude connect:runtime

Module and history

Please see the table below for the historical changes related to applying the Spotless plugin

module apply related PR
:clients future
:connect:api #16299
:connect:basic-auth-extension #16299
:connect:file #16299
:connect:json #16299
:connect:mirror #16299
:connect:mirror-client #16299
:connect:runtime future
:connect:test-plugins #16299
:connect:transforms #16299
:core future
:examples #16296
:generator #16296
:group-coordinator:group-coordinator-api #16298
:group-coordinator #16298
:jmh-benchmarks #16296
:log4j-appender #16296
:metadata #16297
:server #16297
:shell #16296
:storage #16297
:storage:storage-api #16297
:streams future
:streams:examples future
:streams:streams-scala future
:streams:test-utils future
:streams:upgrade-system-tests-0100 future
:streams:upgrade-system-tests-0101 future
:streams:upgrade-system-tests-0102 future
:streams:upgrade-system-tests-0110 future
:streams:upgrade-system-tests-10 future
:streams:upgrade-system-tests-11 future
:streams:upgrade-system-tests-20 future
:streams:upgrade-system-tests-21 future
:streams:upgrade-system-tests-22 future
:streams:upgrade-system-tests-23 future
:streams:upgrade-system-tests-24 future
:streams:upgrade-system-tests-25 future
:streams:upgrade-system-tests-26 future
:streams:upgrade-system-tests-27 future
:streams:upgrade-system-tests-28 future
:streams:upgrade-system-tests-30 future
:streams:upgrade-system-tests-31 future
:streams:upgrade-system-tests-32 future
:streams:upgrade-system-tests-33 future
:streams:upgrade-system-tests-34 future
:streams:upgrade-system-tests-35 future
:streams:upgrade-system-tests-36 future
:streams:upgrade-system-tests-37 future
:trogdor #16296
:raft #16278
:server-common #16172
:transaction-coordinator #16172
:tools #16262
:tools:tools-api #16262

How to test:

We can run ./gradlew spotlessCheck check for code that does not meet requirements.
If we get report that error , we can run ./gradlew spotlessApply to review my code.
In this PR, all change(exclude build.gradle) byspotlessApply`

Copy link
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chia7712 chia7712 merged commit 79b9c44 into apache:trunk Jun 12, 2024
1 check failed
apourchet added a commit to apourchet/kafka that referenced this pull request Jun 12, 2024
commit 9368ef8
Author: Gantigmaa Selenge <[email protected]>
Date:   Wed Jun 12 16:04:24 2024 +0100

    KAFKA-16865: Add IncludeTopicAuthorizedOperations option for DescribeTopicPartitionsRequest (apache#16136)

    Reviewers: Mickael Maison <[email protected]>, Chia-Ping Tsai <[email protected]>, Calvin Liu <[email protected]>, Andrew Schofield <[email protected]>, Apoorv Mittal <[email protected]>

commit 46eb081
Author: gongxuanzhang <[email protected]>
Date:   Wed Jun 12 22:23:39 2024 +0800

    KAFKA-10787 Apply spotless to log4j-appender, trogdor, jmh-benchmarks, examples, shell and generator (apache#16296)

    Reviewers: Chia-Ping Tsai <[email protected]>

commit 79b9c44
Author: gongxuanzhang <[email protected]>
Date:   Wed Jun 12 22:19:47 2024 +0800

    KAFKA-10787 Apply spotless to connect module (apache#16299)

    Reviewers: Chia-Ping Tsai <[email protected]>

commit b5fb654
Author: Abhijeet Kumar <[email protected]>
Date:   Wed Jun 12 19:47:46 2024 +0530

    KAFKA-15265: Dynamic broker configs for remote fetch/copy quotas (apache#16078)

    Reviewers: Kamal Chandraprakash<[email protected]>, Satish Duggana <[email protected]>

commit faee6a4
Author: Dmitry Werner <[email protected]>
Date:   Wed Jun 12 15:44:11 2024 +0500

    MINOR: Use predetermined dir IDs in ReplicationQuotasTest

    Use predetermined directory IDs instead of Uuid.randomUuid() in ReplicationQuotasTest.

    Reviewers: Igor Soarez <[email protected]>

commit 638844f
Author: David Jacot <[email protected]>
Date:   Wed Jun 12 08:29:50 2024 +0200

    KAFKA-16770; [2/2] Coalesce records into bigger batches (apache#16215)

    This patch is the continuation of apache#15964. It introduces the records coalescing to the CoordinatorRuntime. It also introduces a new configuration `group.coordinator.append.linger.ms` which allows administrators to chose the linger time or disable it with zero. The new configuration defaults to 10ms.

    Reviewers: Jeff Kim <[email protected]>, Justine Olshan <[email protected]>

commit 39ffdea
Author: Bruno Cadonna <[email protected]>
Date:   Wed Jun 12 07:51:38 2024 +0200

    KAFKA-10199: Enable state updater by default (apache#16107)

    We have already enabled the state updater by default once.
    However, we ran into issues that forced us to disable it again.
    We think that we fixed those issues. So we want to enable the
    state updater again by default.

    Reviewers: Lucas Brutschy <[email protected]>, Matthias J. Sax <[email protected]>

commit 0782232
Author: Antoine Pourchet <[email protected]>
Date:   Tue Jun 11 22:31:43 2024 -0600

    KAFKA-15045: (KIP-924 pt. 22) Add RackAwareOptimizationParams and other minor TaskAssignmentUtils changes (apache#16294)

    We now provide a way to more easily customize the rack aware
    optimizations that we provide by way of a configuration class called
    RackAwareOptimizationParams.

    We also simplified the APIs for the optimizeXYZ utility functions since
    they were mutating the inputs anyway.

    Reviewers: Anna Sophie Blee-Goldman <[email protected]>

commit 226ac5e
Author: Murali Basani <[email protected]>
Date:   Wed Jun 12 05:38:50 2024 +0200

    KAFKA-16922 Adding unit tests for NewTopic  (apache#16255)

    Reviewers: Chia-Ping Tsai <[email protected]>

commit 23fe71d
Author: Abhijeet Kumar <[email protected]>
Date:   Wed Jun 12 06:27:02 2024 +0530

    KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage (apache#15820)

    - Added the integration of the quota manager to throttle copy requests to the remote storage. Reference KIP-956
    - Added unit-tests for the copy throttling logic.

    Reviewers: Satish Duggana <[email protected]>, Luke Chen <[email protected]>, Kamal Chandraprakash<[email protected]>

commit 2fa2c72
Author: Chris Egerton <[email protected]>
Date:   Tue Jun 11 23:15:07 2024 +0200

    MINOR: Wait for embedded clusters to start before using them in Connect OffsetsApiIntegrationTest (apache#16286)

    Reviewers: Greg Harris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants