Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-10787: Apply spotless to group-coordinator and group-coordinator-api #16298

Merged
merged 5 commits into from
Jun 14, 2024

Conversation

gongxuanzhang
Copy link
Contributor

@gongxuanzhang gongxuanzhang commented Jun 12, 2024

This PR is sub PR from #16097.
It is part of a series of changes to progressively apply [spotless plugin(import-order)] across all modules. In this step, the plugin is activated in the

  • group-coordinator-api
  • group-coordinator

Module and history

Please see the table below for the historical changes related to applying the Spotless plugin

module apply related PR
:clients future
:connect:api #16299
:connect:basic-auth-extension #16299
:connect:file #16299
:connect:json #16299
:connect:mirror #16299
:connect:mirror-client #16299
:connect:runtime future
:connect:test-plugins #16299
:connect:transforms #16299
:core future
:examples #16296
:generator #16296
:group-coordinator:group-coordinator-api #16298
:group-coordinator #16298
:jmh-benchmarks #16296
:log4j-appender #16296
:metadata #16297
:server #16297
:shell #16296
:storage #16297
:storage:storage-api #16297
:streams future
:streams:examples future
:streams:streams-scala future
:streams:test-utils future
:streams:upgrade-system-tests-0100 future
:streams:upgrade-system-tests-0101 future
:streams:upgrade-system-tests-0102 future
:streams:upgrade-system-tests-0110 future
:streams:upgrade-system-tests-10 future
:streams:upgrade-system-tests-11 future
:streams:upgrade-system-tests-20 future
:streams:upgrade-system-tests-21 future
:streams:upgrade-system-tests-22 future
:streams:upgrade-system-tests-23 future
:streams:upgrade-system-tests-24 future
:streams:upgrade-system-tests-25 future
:streams:upgrade-system-tests-26 future
:streams:upgrade-system-tests-27 future
:streams:upgrade-system-tests-28 future
:streams:upgrade-system-tests-30 future
:streams:upgrade-system-tests-31 future
:streams:upgrade-system-tests-32 future
:streams:upgrade-system-tests-33 future
:streams:upgrade-system-tests-34 future
:streams:upgrade-system-tests-35 future
:streams:upgrade-system-tests-36 future
:streams:upgrade-system-tests-37 future
:trogdor #16296
:raft #16278
:server-common #16172
:transaction-coordinator #16172
:tools #16262
:tools:tools-api #16262

How to test:

We can run ./gradlew spotlessCheck check for code that does not meet requirements.
If we get report that error , we can run ./gradlew spotlessApply to review my code.
In this PR, all change(exclude build.gradle) byspotlessApply`

@chia7712
Copy link
Member

@gongxuanzhang please add spotlessJava.dependsOn 'processMessages' to the module having processMessages task. Otherwise, spotless may ignore those generated code

@gongxuanzhang
Copy link
Contributor Author

@gongxuanzhang please add spotlessJava.dependsOn 'processMessages' to the module having processMessages task. Otherwise, spotless may ignore those generated code

I updated it , let’s wait CI

@chia7712
Copy link
Member

@gongxuanzhang could you please add targetExclude '**/generated/**.java' to skip generated code? We should keep the generated code as they are.

@gongxuanzhang
Copy link
Contributor Author

It seems to be working

@gongxuanzhang
Copy link
Contributor Author

Failed test

JDK 21 and Scala 2.13

test jira
testSyncTopicConfigs https://issues.apache.org/jira/browse/KAFKA-14971
testConsumptionWithBrokerFailures https://issues.apache.org/jira/browse/KAFKA-15146
testCoordinatorFailover https://issues.apache.org/jira/browse/KAFKA-9007
shouldBootstrapTwoBrokersWithFollowerThrottle https://issues.apache.org/jira/browse/KAFKA-4265

JDK 8 and Scala 2.12

test jira
testAlterSinkConnectorOffsetsZombieSinkTasks https://issues.apache.org/jira/browse/KAFKA-15917
shouldRestoreState https://issues.apache.org/jira/browse/KAFKA-10405

@gongxuanzhang
Copy link
Contributor Author

@chia7712 plz take a look

Copy link
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants