Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VTA] Bringing group convolution support #4421

Merged
merged 6 commits into from
Dec 9, 2019

Conversation

tmoreau89
Copy link
Contributor

This PR brings group convolution operator support to VTA.

@tmoreau89
Copy link
Contributor Author

Added the tophub schedules for Pynq group convolutions running mobilenet-g from the VTA paper: tlc-pack/tophub@9f9fdba

@tmoreau89 tmoreau89 changed the title [WIP][VTA] Bringing group convolution support [VTA] Bringing group convolution support Nov 26, 2019
@tmoreau89
Copy link
Contributor Author

Removed WIP tag; PR ready for review!

Copy link
Member

@liangfu liangfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmoreau89 Thanks for bringing the new feature. I left some comments, otherwise LGTM.

vta/scripts/tune_group_conv2d.py Outdated Show resolved Hide resolved
vta/scripts/tune_group_conv2d.py Outdated Show resolved Hide resolved
Copy link
Member

@liangfu liangfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tqchen
Copy link
Member

tqchen commented Dec 9, 2019

@tmoreau89 feel free to merge

@tmoreau89 tmoreau89 merged commit 6ab1580 into apache:master Dec 9, 2019
@tmoreau89
Copy link
Contributor Author

Thank you @liangfu and @tqchen , the PR is merged.

zxy844288792 pushed a commit to zxy844288792/tvm that referenced this pull request Dec 13, 2019
* group conv operator support for VTA

* autotvm tuning script for group conv2d

* lint fix

* lint fix

* lint fix

* addressing comments
zxy844288792 pushed a commit to neo-ai/tvm that referenced this pull request Dec 13, 2019
* group conv operator support for VTA

* autotvm tuning script for group conv2d

* lint fix

* lint fix

* lint fix

* addressing comments
@tmoreau89 tmoreau89 deleted the groupconv branch February 13, 2020 21:27
tqchen pushed a commit to tqchen/tvm that referenced this pull request Mar 29, 2020
* group conv operator support for VTA

* autotvm tuning script for group conv2d

* lint fix

* lint fix

* lint fix

* addressing comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants