add BarrierEvent #60
Merged
add BarrierEvent #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
============================================
+ Coverage 84.53% 84.60% +0.06%
- Complexity 738 745 +7
============================================
Files 57 58 +1
Lines 2115 2150 +35
Branches 316 320 +4
============================================
+ Hits 1788 1819 +31
Misses 188 188
- Partials 139 143 +4
Continue to review full report at Codecov.
|
javeme
reviewed
Jan 7, 2021
| } | ||
| } | ||
|
|
||
| public boolean await(long time) throws InterruptedException { |
There was a problem hiding this comment.
also add doc
and rename to timeout
|
|
||
| public boolean await(long time) throws InterruptedException { | ||
| E.checkArgument(time >= 0L, | ||
| "The time must be >= 0, but got '%d'.", |
| import com.baidu.hugegraph.testutil.Assert; | ||
|
|
||
| public class BarrierEventTest { | ||
|
|
javeme
requested changes
Jan 7, 2021
| barrierEvent.signalAll(); | ||
| signaled = barrierEvent.await(1L); | ||
| Assert.assertTrue(signaled); | ||
| } |
There was a problem hiding this comment.
add test for multi-threaded scene
javeme
requested changes
Jan 8, 2021
| @@ -65,6 +68,40 @@ public void testSignal() throws InterruptedException { | |||
| Assert.assertTrue(signaled); | |||
| } | |||
|
|
|||
| @Test(timeout = 5000) | |||
| public void testSignalMultiThread() throws InterruptedException { | |||
| barrierEvent.await(); | ||
| result.incrementAndGet(); | ||
| } catch (InterruptedException e) { | ||
| // Do nothing |
| try { | ||
| waitLatch.countDown(); | ||
| barrierEvent.await(); | ||
| result.incrementAndGet(); |
| barrierEvent.signal(); | ||
| signalLatch.countDown(); | ||
| }); | ||
| signalThread.start(); |
| barrierEvent.signalAll(); | ||
| latch.countDown(); | ||
| }); | ||
| signalThread.start(); |
| waitLatch.await(); | ||
| signalLatch.await(); | ||
| TimeUnit.MICROSECONDS.sleep(100); | ||
| executorService.shutdownNow(); |
There was a problem hiding this comment.
also call executorService.await()
…ignalAll after await with multy thread.
javeme
reviewed
Jan 9, 2021
| signalLatch.await(); | ||
| TimeUnit.MICROSECONDS.sleep(100); | ||
| TimeUnit.MILLISECONDS.sleep(10L); |
There was a problem hiding this comment.
Yes, if reach this line, it indicates the signal thread has signaled, but the wait thread may not be notified and executed.
There was a problem hiding this comment.
please explain why instead of what,I mean seems we can remove the sleep
| executorService.awaitTermination(1L, TimeUnit.SECONDS); | ||
| Assert.assertEquals(waitThreadNum, eventCount.get()); | ||
| Assert.assertEquals(0, waitThreadInterruptedCount.get()); | ||
| Assert.assertEquals(0, signalThreadInterruptedCount.get()); |
There was a problem hiding this comment.
add testSignalAllByMultiThreadWithSignalAwaitConcurrent for signalAll and await at the same time
javeme
requested changes
Jan 9, 2021
| AtomicInteger eventCount = new AtomicInteger(0); | ||
| AtomicInteger waitThreadInterruptedCount = new AtomicInteger(0); | ||
| AtomicInteger signalThreadInterruptedCount = new AtomicInteger(0); | ||
| int waitThreadNum = 10; |
| signalLatch.await(); | ||
| TimeUnit.MICROSECONDS.sleep(100); | ||
| TimeUnit.MILLISECONDS.sleep(10L); |
There was a problem hiding this comment.
please explain why instead of what,I mean seems we can remove the sleep
javeme
previously approved these changes
Jan 10, 2021
zhoney
requested changes
Jan 11, 2021
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| <groupId>com.baidu.hugegraph</groupId> | |||
| <artifactId>hugegraph-common</artifactId> | |||
| <version>1.8.2</version> | |||
|
|
||
| private final Lock lock = new ReentrantLock(); | ||
| private final Condition cond = lock.newCondition(); | ||
| private boolean signaled = false; |
zhoney
approved these changes
Jan 11, 2021
javeme
approved these changes
Jan 11, 2021
xuliguov5
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.