-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add BarrierEvent #60
add BarrierEvent #60
Changes from 4 commits
ff2a725
40c766c
e01c9e0
bee4569
6710980
5b4262e
2de47e4
7ffdf85
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,107 @@ | ||
/* | ||
* | ||
* Copyright 2017 HugeGraph Authors | ||
* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with this | ||
* work for additional information regarding copyright ownership. The ASF | ||
* licenses this file to You under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
* License for the specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
package com.baidu.hugegraph.concurrent; | ||
|
||
import java.util.concurrent.TimeUnit; | ||
import java.util.concurrent.locks.Condition; | ||
import java.util.concurrent.locks.Lock; | ||
import java.util.concurrent.locks.ReentrantLock; | ||
|
||
import com.baidu.hugegraph.util.E; | ||
|
||
public class BarrierEvent { | ||
|
||
private final Lock lock = new ReentrantLock(); | ||
private final Condition cond = lock.newCondition(); | ||
private boolean signaled = false; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. volatile |
||
|
||
/** | ||
* Wait forever until the signal is received. | ||
* @return true if signal is received | ||
* @throws InterruptedException if interrupted. | ||
*/ | ||
public void await() throws InterruptedException { | ||
this.lock.lock(); | ||
try { | ||
while (!this.signaled) { | ||
this.cond.await(); | ||
} | ||
} finally { | ||
this.lock.unlock(); | ||
} | ||
} | ||
|
||
/** | ||
* Wait specified time in milliseconds. | ||
* @param timeout: the time in millisecond to wait. | ||
* @return true if signal is received, false if time out. | ||
*/ | ||
public boolean await(long timeout) throws InterruptedException { | ||
E.checkArgument(timeout >= 0L, | ||
"The time must be >= 0, but got '%d'.", | ||
timeout); | ||
long deadline = System.currentTimeMillis() + timeout; | ||
this.lock.lock(); | ||
try { | ||
while (!this.signaled) { | ||
timeout = deadline - System.currentTimeMillis(); | ||
if (timeout > 0) { | ||
this.cond.await(timeout, TimeUnit.MILLISECONDS); | ||
} | ||
if (System.currentTimeMillis() >= deadline) { | ||
return this.signaled; | ||
} | ||
} | ||
} finally { | ||
this.lock.unlock(); | ||
} | ||
return true; | ||
} | ||
|
||
public void reset() { | ||
this.lock.lock(); | ||
try { | ||
this.signaled = false; | ||
} finally { | ||
this.lock.unlock(); | ||
} | ||
} | ||
|
||
public void signal() { | ||
this.lock.lock(); | ||
try { | ||
this.signaled = true; | ||
this.cond.signal(); | ||
} finally { | ||
this.lock.unlock(); | ||
} | ||
} | ||
|
||
public void signalAll() { | ||
this.lock.lock(); | ||
try { | ||
this.signaled = true; | ||
this.cond.signalAll(); | ||
} finally { | ||
this.lock.unlock(); | ||
} | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,144 @@ | ||
package com.baidu.hugegraph.unit.concurrent; | ||
|
||
import java.util.concurrent.CountDownLatch; | ||
import java.util.concurrent.ExecutorService; | ||
import java.util.concurrent.Executors; | ||
import java.util.concurrent.TimeUnit; | ||
import java.util.concurrent.atomic.AtomicInteger; | ||
|
||
import org.junit.Test; | ||
|
||
import com.baidu.hugegraph.concurrent.BarrierEvent; | ||
import com.baidu.hugegraph.testutil.Assert; | ||
|
||
public class BarrierEventTest { | ||
|
||
@Test(timeout = 5000) | ||
public void testAWait() throws InterruptedException { | ||
BarrierEvent barrierEvent = new BarrierEvent(); | ||
AtomicInteger result = new AtomicInteger(0); | ||
CountDownLatch latch = new CountDownLatch(2); | ||
Thread awaitThread = new Thread(() -> { | ||
try { | ||
barrierEvent.await(); | ||
result.incrementAndGet(); | ||
} catch (InterruptedException e) { | ||
// Do nothing. | ||
} finally { | ||
latch.countDown(); | ||
} | ||
}); | ||
awaitThread.start(); | ||
Thread signalThread = new Thread(() -> { | ||
barrierEvent.signalAll(); | ||
latch.countDown(); | ||
}); | ||
signalThread.start(); | ||
latch.await(); | ||
Assert.assertEquals(1, result.get()); | ||
} | ||
|
||
@Test | ||
public void testAWaitWithTimeout() throws InterruptedException { | ||
BarrierEvent barrierEvent = new BarrierEvent(); | ||
boolean signaled = barrierEvent.await(1L); | ||
Assert.assertFalse(signaled); | ||
} | ||
|
||
@Test | ||
public void testReset() throws InterruptedException { | ||
BarrierEvent barrierEvent = new BarrierEvent(); | ||
boolean signaled = barrierEvent.await(1L); | ||
Assert.assertFalse(signaled); | ||
barrierEvent.signal(); | ||
signaled = barrierEvent.await(1L); | ||
Assert.assertTrue(signaled); | ||
barrierEvent.reset(); | ||
signaled = barrierEvent.await(1L); | ||
Assert.assertFalse(signaled); | ||
} | ||
|
||
@Test | ||
public void testSignal() throws InterruptedException { | ||
BarrierEvent barrierEvent = new BarrierEvent(); | ||
boolean signaled = barrierEvent.await(1L); | ||
Assert.assertFalse(signaled); | ||
barrierEvent.signal(); | ||
signaled = barrierEvent.await(1L); | ||
Assert.assertTrue(signaled); | ||
javeme marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
|
||
@Test(timeout = 5000) | ||
public void testSignalMultiThread() throws InterruptedException { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. testSignalByMultiThread |
||
BarrierEvent barrierEvent = new BarrierEvent(); | ||
AtomicInteger result = new AtomicInteger(0); | ||
int waitThreadNum = 10; | ||
ExecutorService executorService = | ||
Executors.newFixedThreadPool(waitThreadNum); | ||
CountDownLatch waitLatch = new CountDownLatch(waitThreadNum); | ||
CountDownLatch signalLatch = new CountDownLatch(1); | ||
for (int i = 0; i < waitThreadNum; i++) { | ||
executorService.submit(() -> { | ||
try { | ||
waitLatch.countDown(); | ||
barrierEvent.await(); | ||
result.incrementAndGet(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. eventCount |
||
} catch (InterruptedException e) { | ||
// Do nothing | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. interruptedCount |
||
} | ||
}); | ||
} | ||
|
||
Thread signalThread = new Thread(() -> { | ||
barrierEvent.signal(); | ||
signalLatch.countDown(); | ||
}); | ||
signalThread.start(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. test signal first or last |
||
waitLatch.await(); | ||
signalLatch.await(); | ||
TimeUnit.MICROSECONDS.sleep(100); | ||
executorService.shutdownNow(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. also call executorService.await() |
||
|
||
Assert.assertEquals(1, result.get()); | ||
} | ||
|
||
@Test | ||
public void testSignalAll() throws InterruptedException { | ||
BarrierEvent barrierEvent = new BarrierEvent(); | ||
boolean signaled = barrierEvent.await(1L); | ||
Assert.assertFalse(signaled); | ||
barrierEvent.signalAll(); | ||
signaled = barrierEvent.await(1L); | ||
Assert.assertTrue(signaled); | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. add test for multi-threaded scene |
||
|
||
@Test(timeout = 5000) | ||
public void testSignalAllMultiThread() throws InterruptedException { | ||
BarrierEvent barrierEvent = new BarrierEvent(); | ||
AtomicInteger result = new AtomicInteger(0); | ||
int waitThreadNum = 10; | ||
ExecutorService executorService = | ||
Executors.newFixedThreadPool(waitThreadNum); | ||
CountDownLatch latch = new CountDownLatch(waitThreadNum + 1); | ||
for (int i = 0; i < waitThreadNum; i++) { | ||
executorService.submit(() -> { | ||
try { | ||
barrierEvent.await(); | ||
result.incrementAndGet(); | ||
latch.countDown(); | ||
} catch (InterruptedException e) { | ||
// Do nothing | ||
} | ||
}); | ||
} | ||
Thread signalThread = new Thread(() -> { | ||
barrierEvent.signalAll(); | ||
latch.countDown(); | ||
}); | ||
signalThread.start(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ditto |
||
latch.await(); | ||
executorService.shutdownNow(); | ||
|
||
Assert.assertEquals(waitThreadNum, result.get()); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also change line 269