add BspEvent and LockEvent #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javeme
requested changes
Jan 6, 2021
| this.lock.lock(); | ||
| try { | ||
| while (!this.signaled) { | ||
| time = deadline - System.currentTimeMillis(); |
|
|
||
| public class LockEvent implements BspEvent { | ||
|
|
||
| private Lock lock = new ReentrantLock(); |
| } | ||
|
|
||
| @Override | ||
| public boolean waitMillis(long time) { |
|
|
||
| @Override | ||
| public void waitOrFail(long time) { | ||
| E.checkArgument(time >= 0L, "The time must be >= 0, but got %d.", |
| } | ||
| } | ||
| } catch (InterruptedException e) { | ||
| throw new ComputerException( "Interrupted while waiting %d. ", e, |
There was a problem hiding this comment.
code style:
remove unused " " and "."
There was a problem hiding this comment.
also improve message: "Interrupted while waiting 10" is confusing
| long deadline = System.currentTimeMillis() + time; | ||
| while (!this.waitMillis(time)) { | ||
| if (System.currentTimeMillis() > deadline) { | ||
| throw new ComputerException("Timeout waiting, time = '%d'.", |
There was a problem hiding this comment.
improve message: wait for what?
xuliguov5
suggested changes
Jan 6, 2021
| boolean waitMillis(long time); | ||
|
|
||
| /** | ||
| * Wait specified time in millisecond, for throw ComputerException if |
| } | ||
|
|
||
| @Override | ||
| public void signal() { |
| @Test | ||
| public void testWaitOrFail() { | ||
| LockEvent lockEvent = new LockEvent(); | ||
| Assert.assertThrows(ComputerException.class, () -> { |
|
commit to hugegraph-common apache/incubator-hugegraph-commons#60 |
yandababa2
pushed a commit
to yandababa2/hugegraph-computer
that referenced
this pull request
Oct 22, 2021
* add HugeInputSplitFetcher#client timeout * skip edge when fail to convert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.