Spark: Read DVs when reading from .position_deletes table #11657
+419
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
commented
Nov 26, 2024
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/PositionDeletesRowReader.java
Outdated
Show resolved
Hide resolved
aokolnychyi
reviewed
Nov 27, 2024
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/DVIterable.java
Outdated
Show resolved
Hide resolved
aokolnychyi
reviewed
Nov 27, 2024
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/DVIterable.java
Outdated
Show resolved
Hide resolved
nastra
force-pushed
the
dv-iterable-for-position-deletes
branch
2 times, most recently
from
b347427
to
cd35ea5
Compare
nastra
force-pushed
the
dv-iterable-for-position-deletes
branch
2 times, most recently
from
2ab2cda
to
b79a7da
Compare
nastra
force-pushed
the
dv-iterable-for-position-deletes
branch
from
b79a7da
to
2512b5f
Compare
singhpk234
reviewed
Nov 28, 2024
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/DVIterable.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Override | ||
| public CloseableIterator<InternalRow> iterator() { | ||
| PuffinReader reader = builder.build(); |
There was a problem hiding this comment.
[optional] might be too much, but can we have one reader per DV file ? considering specifically for this use case we will have to read all the blobs in the DV file eventually.
There was a problem hiding this comment.
do you have a particular use case in mind as this isn't something that is being needed currently when reading the PositionDeletesTable?
nastra
force-pushed
the
dv-iterable-for-position-deletes
branch
from
9a47998
to
3e1bafe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is part of #11122 and has been extracted from #11545