HBASE-26328 Clone snapshot doesn't load reference files into FILE SFT impl #3749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…racking logic Signed-off-by: Wellington Chevreuil <[email protected]>
Signed-off-by: Wellington Chevreuil <[email protected]>
) Signed-off-by: Duo Zhang <[email protected]>
…g from different store file tracker implementations (apache#3656) Signed-off-by: Wellington Chevreuil <[email protected]>
…iptor when creating table (apache#3666) Signed-off-by: Duo Zhang <[email protected]>
… file tracker implementation (apache#3665) Signed-off-by: Wellington Chevreuil <[email protected]>
… tracker (apache#3681) Signed-off-by: Josh Elser <[email protected]>
Signed-off-by: Wellington Chevreuil <[email protected]> Reviewed-by: Josh Elser <[email protected]>
…racking logic Signed-off-by: Wellington Chevreuil <[email protected]>
Signed-off-by: Wellington Chevreuil <[email protected]>
) Signed-off-by: Duo Zhang <[email protected]>
…g from different store file tracker implementations (apache#3656) Signed-off-by: Wellington Chevreuil <[email protected]>
…iptor when creating table (apache#3666) Signed-off-by: Duo Zhang <[email protected]>
… file tracker implementation (apache#3665) Signed-off-by: Wellington Chevreuil <[email protected]>
… tracker (apache#3681) Signed-off-by: Josh Elser <[email protected]>
Signed-off-by: Wellington Chevreuil <[email protected]> Reviewed-by: Josh Elser <[email protected]>
… is set in global config Removed init() method from StoreFileTrakcerBase. Added check in FileBasedStoreFileTracker constructor to ignore null StoreContext or StoreContext instances that don't have store dir info.
… impl Change-Id: I58ce5ef6bad9af6605c5f6cd041c85f48d36169a adding UT Change-Id: Ic0a0f8540a12dd7bcde5663c770e2e0d49c61fb6
Change-Id: Ia4482881e46b2521683d23a1a2ea84d7a7368109
apache#3721) Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Josh Elser <[email protected]>
wchevreuil
commented
Oct 13, 2021
| super(conf, isPrimaryReplica, ctx); | ||
| } | ||
|
|
||
| public void setReferenceFiles(List<StoreFileInfo> files) { |
There was a problem hiding this comment.
This is called by RestoreSnapshotHelper, once it has built a list of reference files on the snapshotted table store dir.
wchevreuil
commented
Oct 13, 2021
| * <p/> | ||
| */ | ||
| @InterfaceAudience.Private | ||
| public class SnapshotStoreFileTracker extends MigrationStoreFileTracker { |
There was a problem hiding this comment.
Created this as an extension of MigrationStoreFileTracker for the snapshot recovery case only. Currently, MigrationStoreFileTracker is package private, didn't want to expose it just for the sake of snasphots clone/restore.
There was a problem hiding this comment.
Please see this post:
I think the decision was the snapshot is just a set of HFiles, it just records the Store File Tracker implementation in the table descriptor, but we will not use it to record the store files in the snapshot. So I do not think we need the 'src' store file tracker here. We just get the files for a store, and then insert it into the target store file tracker. Not sure if I understand correctly here.
There was a problem hiding this comment.
So when restoring or cloning to existing table, because we may have to keep some of the existing hfiles that are still valid, but remove some others, we can't rely on the pre-existing record of "tracked files". That means we can't call StoreFileTracker.call, nor StoreFileTracker.replace. We need to reset the SFT registry with the new list of files built by RestoreSnapshotHelper. That means we need to call StoreFileTrackerBase.set, but this is package private. So we could either expose StoreFileTrackerBase, or extend MigrationStoreFileTracker in such way that you can properly initialise the SFT with the list of files built by RestoreSnapshotHelper.
wchevreuil
commented
Oct 13, 2021
| protected SnapshotStoreFileTracker(Configuration conf, boolean isPrimaryReplica, | ||
| StoreContext ctx) { | ||
| super(conf, isPrimaryReplica, ctx); | ||
| Preconditions.checkArgument(src instanceof SourceTracker, |
There was a problem hiding this comment.
This is to ensure this will never be used as a general purpose "migration" tracker.
|
💔 -1 overall
This message was automatically generated. |
Change-Id: Idbebddc6e455ab3630942f1e982bc9da91cc6a31
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
approved these changes
Oct 22, 2021
| clonedFiles.add(new StoreFileInfo(conf, fs, new Path(familyDir, file), true)); | ||
| } | ||
| } | ||
| //we don't need to track regions under mobdir |
There was a problem hiding this comment.
I think you mean we do not need to track store files under mobdir?
There was a problem hiding this comment.
Yep. Let me change that comment and also add extra comments on HFileLink.create explaining why we now throw exception there.
Change-Id: I08378c1254aaca82e732248826a5394835fba8b5
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Apache9
pushed a commit
that referenced
this pull request
Nov 6, 2021
… impl (#3749) Signed-off-by: Duo Zhang <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Nov 9, 2021
… impl (#3749) Signed-off-by: Duo Zhang <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Nov 27, 2021
… impl (#3749) Signed-off-by: Duo Zhang <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Dec 6, 2021
… impl (#3749) Signed-off-by: Duo Zhang <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Dec 17, 2021
… impl (#3749) Signed-off-by: Duo Zhang <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Dec 22, 2021
… impl (#3749) Signed-off-by: Duo Zhang <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Jan 1, 2022
… impl (#3749) Signed-off-by: Duo Zhang <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Jan 2, 2022
… impl (#3749) Signed-off-by: Duo Zhang <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Jan 2, 2022
… impl (#3749) Signed-off-by: Duo Zhang <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Jan 4, 2022
… impl (#3749) Signed-off-by: Duo Zhang <[email protected]>
apurtell
pushed a commit
to apurtell/hbase
that referenced
this pull request
Mar 18, 2022
… impl (apache#3749) Signed-off-by: Duo Zhang <[email protected]>
apurtell
pushed a commit
to apurtell/hbase
that referenced
this pull request
Mar 19, 2022
… impl (apache#3749) Signed-off-by: Duo Zhang <[email protected]>
apurtell
pushed a commit
to apurtell/hbase
that referenced
this pull request
Mar 25, 2022
… impl (apache#3749) Signed-off-by: Duo Zhang <[email protected]>
apurtell
pushed a commit
to apurtell/hbase
that referenced
this pull request
Mar 26, 2022
… impl (apache#3749) Signed-off-by: Duo Zhang <[email protected]>
apurtell
added a commit
to apurtell/hbase
that referenced
this pull request
Mar 26, 2022
…others) to branch-2.5 Previous cherry picks: commit 6aaef89 HBASE-26064 Introduce a StoreFileTracker to abstract the store file tracking logic commit 43b40e9 HBASE-25988 Store the store file list by a file apache#3578) commit 6e05376 HBASE-26079 Use StoreFileTracker when splitting and merging apache#3617) commit 090b2fe HBASE-26224 HBASE-26224 Introduce a MigrationStoreFileTracker to support migratin… apache#3656) commit 0ee1689 HBASE-26246 Persist the StoreFileTracker configurations to TableDescriptor when creating table apache#3666) commit 2052e80 HBASE-26248 Should find a suitable way to let users specify the store… apache#3665) commit 5ff0f98 HBASE-26264 Add more checks to prevent misconfiguration on store file… apache#3681) commit fc4f6d1 HBASE-26280 HBASE-26280 Use store file tracker when snapshoting apache#3685) commit 06db852 HBASE-26326 CreateTableProcedure fails when FileBasedStoreFileTracker… apache#3721) commit e4e7cf8 HBASE-26386 Refactor StoreFileTracker implementations to expose the s… apache#3774) commit 08d1171 HBASE-26328 Clone snapshot doesn't load reference files into FILE SFT impl apache#3749) commit 8bec26e HBASE-26263 [Rolling Upgrading] Persist the StoreFileTracker configur… apache#3700) commit a288365 HBASE-26271: Cleanup the broken store files under data directory apache#3786) commit d00b5fa HBASE-26454 CreateTableProcedure still relies on temp dir and renames… apache#3845) commit 771e552 HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot commit f16b7b1 HBASE-26265 Update ref guide to mention the new store file tracker im… apache#3942) commit 755b3b4 HBASE-26585 Add SFT configuration to META table descriptor when creating META apache#3998) commit 39c42c7 HBASE-26639 The implementation of TestMergesSplitsAddToTracker is pro… apache#4010) commit 6e1f5b7 HBASE-26586 Should not rely on the global config when setting SFT implementation for a table while upgrading apache#4006) commit f1dd865 HBASE-26654 ModifyTableDescriptorProcedure shoud load TableDescriptor… apache#4034) commit 8fbc9a2 HBASE-26674 Should modify filesCompacting under storeWriteLock apache#4040) commit 5aa0fd2 HBASE-26675 Data race on Compactor.writer apache#4035) commit 3021c58 HBASE-26700 The way we bypass broken track file is not enough in Stor… apache#4055) commit a8b68c9 HBASE-26690 Modify FSTableDescriptors to not rely on renaming when wr… apache#4054) commit dffeb8e HBASE-26587 Introduce a new Admin API to change SFT implementation (#… apache#4080) commit b265fe5 HBASE-26673 Implement a shell command for change SFT implementation apache#4113) commit 4cdb380 HBASE-26640 Reimplement master local region initialization to better … apache#4111) commit 77bb153 HBASE-26707: Reduce number of renames during bulkload (apache#4066) apache#4122) commit a4b192e HBASE-26611 Changing SFT implementation on disabled table is dangerous apache#4082) commit d3629bb HBASE-26837 Set SFT config when creating TableDescriptor in TestClone… apache#4226) commit 541d748 HBASE-26881 Backport HBASE-25368 to branch-2 (apache#4267) Fixups for precommit error prone, checkstyle, and javadoc warnings after applying cherry picks. Signed-off-by: Josh Elser <[email protected]> Reviewed-by: Wellington Ramos Chevreuil <[email protected]>
apurtell
pushed a commit
that referenced
this pull request
Mar 26, 2022
… impl (#3749) Signed-off-by: Duo Zhang <[email protected]>
apurtell
added a commit
that referenced
this pull request
Mar 26, 2022
…others) to branch-2.5 Previous cherry picks: commit 6aaef89 HBASE-26064 Introduce a StoreFileTracker to abstract the store file tracking logic commit 43b40e9 HBASE-25988 Store the store file list by a file #3578) commit 6e05376 HBASE-26079 Use StoreFileTracker when splitting and merging #3617) commit 090b2fe HBASE-26224 HBASE-26224 Introduce a MigrationStoreFileTracker to support migratin… #3656) commit 0ee1689 HBASE-26246 Persist the StoreFileTracker configurations to TableDescriptor when creating table #3666) commit 2052e80 HBASE-26248 Should find a suitable way to let users specify the store… #3665) commit 5ff0f98 HBASE-26264 Add more checks to prevent misconfiguration on store file… #3681) commit fc4f6d1 HBASE-26280 HBASE-26280 Use store file tracker when snapshoting #3685) commit 06db852 HBASE-26326 CreateTableProcedure fails when FileBasedStoreFileTracker… #3721) commit e4e7cf8 HBASE-26386 Refactor StoreFileTracker implementations to expose the s… #3774) commit 08d1171 HBASE-26328 Clone snapshot doesn't load reference files into FILE SFT impl #3749) commit 8bec26e HBASE-26263 [Rolling Upgrading] Persist the StoreFileTracker configur… #3700) commit a288365 HBASE-26271: Cleanup the broken store files under data directory #3786) commit d00b5fa HBASE-26454 CreateTableProcedure still relies on temp dir and renames… #3845) commit 771e552 HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot commit f16b7b1 HBASE-26265 Update ref guide to mention the new store file tracker im… #3942) commit 755b3b4 HBASE-26585 Add SFT configuration to META table descriptor when creating META #3998) commit 39c42c7 HBASE-26639 The implementation of TestMergesSplitsAddToTracker is pro… #4010) commit 6e1f5b7 HBASE-26586 Should not rely on the global config when setting SFT implementation for a table while upgrading #4006) commit f1dd865 HBASE-26654 ModifyTableDescriptorProcedure shoud load TableDescriptor… #4034) commit 8fbc9a2 HBASE-26674 Should modify filesCompacting under storeWriteLock #4040) commit 5aa0fd2 HBASE-26675 Data race on Compactor.writer #4035) commit 3021c58 HBASE-26700 The way we bypass broken track file is not enough in Stor… #4055) commit a8b68c9 HBASE-26690 Modify FSTableDescriptors to not rely on renaming when wr… #4054) commit dffeb8e HBASE-26587 Introduce a new Admin API to change SFT implementation (#… #4080) commit b265fe5 HBASE-26673 Implement a shell command for change SFT implementation #4113) commit 4cdb380 HBASE-26640 Reimplement master local region initialization to better … #4111) commit 77bb153 HBASE-26707: Reduce number of renames during bulkload (#4066) #4122) commit a4b192e HBASE-26611 Changing SFT implementation on disabled table is dangerous #4082) commit d3629bb HBASE-26837 Set SFT config when creating TableDescriptor in TestClone… #4226) commit 541d748 HBASE-26881 Backport HBASE-25368 to branch-2 (#4267) Fixups for precommit error prone, checkstyle, and javadoc warnings after applying cherry picks. Signed-off-by: Josh Elser <[email protected]> Reviewed-by: Wellington Ramos Chevreuil <[email protected]>
vinayakphegde
pushed a commit
to vinayakphegde/hbase
that referenced
this pull request
Apr 4, 2024
… impl (apache#3749) Change-Id: If4b96a773e5b9d63fb601162f3c565d6d61c7de4 Signed-off-by: Duo Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.