HBASE-26326 CreateTableProcedure fails when FileBasedStoreFileTracker… #3721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…racking logic Signed-off-by: Wellington Chevreuil <[email protected]>
Signed-off-by: Wellington Chevreuil <[email protected]>
) Signed-off-by: Duo Zhang <[email protected]>
…g from different store file tracker implementations (apache#3656) Signed-off-by: Wellington Chevreuil <[email protected]>
…iptor when creating table (apache#3666) Signed-off-by: Duo Zhang <[email protected]>
… file tracker implementation (apache#3665) Signed-off-by: Wellington Chevreuil <[email protected]>
… tracker (apache#3681) Signed-off-by: Josh Elser <[email protected]>
Signed-off-by: Wellington Chevreuil <[email protected]> Reviewed-by: Josh Elser <[email protected]>
|
In general I do not like that we introduce a new init method but do not call it when verifying... I think we should try to provide more things when constructing the StoreFileTracker. The current implementations are already lazy enough as we do not actually touch the storage, we just create some in memory objects... So why not just pass in a RegionFileSystem for this case? Just like what we have done in the split/merge procedures. Thanks. |
It's a mean to separate instantiation of SFT impls, from actual init logic. In this particular case, we need SFT impl specific logic about setting configs before we can effectively start a SFT tracker properly.
We don't have store info at CreateTable procedure time, we don't even have the regions yet by then, so how can we create a RegionFileSystem? |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Yes, this is a problem. In the first place I thought maybe we could just create a default region and then create a region file system, but it seems to tricky and a bit ugly. So we should let the implementation class to know this. A possible way is to pass in a null StoreContext, and the implementation class should check whether the StoreContext is null, if so, then it should construct itself in the 'persist store tracker configurations' mode. Or another possible way is to force every store file tracker implementation has a static method, for persisting the store file tracker configurations. We could have separated logic in this method, so normal code path does not need to deal with null StoreContext. I think the latter one will be cleaner but not sure if we can force the implementation class has a static method at compile time. But at least, we could introduce a UT for checking this. WDYT? Thanks. |
That could be an option, despite looking a bit hacky. Alternatively, we could ensure init() is called prior to start adding/loading/replacing store files. WDYT?
That was exactly my first idea, but the lack of enforcement of static methods on implementations is a problem, IMO, which led me to the alternative solution.
|
|
The UT I mean is to check whether we have the static method for each implementation class. This is possible. I think this will be cleaner way. I also want to introduce a init method in the past when implementing migration store file tracker, as we will not always call load when migrating, but finally I just added a check in the StoreFileListFile, to avoid adding extra methods. For me I prefer we keep the interface simple, unless there are no other choices. WDYT? Thanks. |
|
I'm sorry @Apache9 , but why did you force push all these commits into the branch? I believe it had no conflicts with HBASE-26067 before. |
|
I just rebased HBASE-26067 against the newest master branch, and seems GitHub can not identify this type of rebase so it will show all the commits in the PR. You can do a cherry-pick to the newest HBASE-26067 and then do a force push to your branch. Sorry for the inconvenience. In the future I will shout before doing the rebase to let others know. |
No problem, just wanted to make sure on the reason. Let me do the cherry-pick. |
… is set in global config Removed init() method from StoreFileTrakcerBase. Added check in FileBasedStoreFileTracker constructor to ignore null StoreContext or StoreContext instances that don't have store dir info.
wchevreuil
force-pushed
the
HBASE-26326
branch
from
8cf2119 to
1727115
Compare
|
I'm not sure why github is showing all these additional commits, it should have the option to rebase. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
joshelser
reviewed
Oct 13, 2021
| * <p/> | ||
| * This is used to avoid accidentally data loss when changing the cluster level store file tracker | ||
| * implementation, and also possible misconfiguration between master and region servers. | ||
| * <p/> | ||
| * See HBASE-26246 for more details. | ||
| * @param builder The table descriptor builder for the given table. | ||
| */ | ||
| void persistConfiguration(TableDescriptorBuilder builder); | ||
| TableDescriptor updateWithTrackerConfigs(TableDescriptorBuilder builder); |
There was a problem hiding this comment.
Maybe buildWithTrackerConfigs if you're returning the TableDescriptor instead of the TableDescriptorBuilder. IMO, i'd just return the Builder back and let the caller build() when they're ready.
There was a problem hiding this comment.
IMO, i'd just return the Builder back and let the caller build() when they're ready.
Yeah, I guess that would be better. WDYT, @Apache9 ?
There was a problem hiding this comment.
Just return void is enough. The upper layer could build it after calling this method.
...-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestCreateTableProcedure.java
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
Apache9
approved these changes
Oct 13, 2021
There was a problem hiding this comment.
OVerall LGTM.
The only thing is what Josh proposed, let's not return TableDescriptor for StoreFileTracker.updateWithTrackConfigs.
Thanks @wchevreuil for your patience.
|
🎊 +1 overall
This message was automatically generated. |
joshelser
approved these changes
Oct 13, 2021
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
pushed a commit
that referenced
this pull request
Oct 14, 2021
#3721) Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Josh Elser <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Oct 21, 2021
#3721) Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Josh Elser <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Nov 6, 2021
#3721) Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Josh Elser <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Nov 9, 2021
#3721) Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Josh Elser <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Nov 27, 2021
#3721) Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Josh Elser <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Dec 6, 2021
#3721) Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Josh Elser <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Dec 17, 2021
#3721) Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Josh Elser <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Dec 22, 2021
#3721) Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Josh Elser <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Jan 1, 2022
#3721) Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Josh Elser <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Jan 2, 2022
#3721) Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Josh Elser <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Jan 2, 2022
#3721) Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Josh Elser <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Jan 4, 2022
#3721) Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Josh Elser <[email protected]>
apurtell
pushed a commit
to apurtell/hbase
that referenced
this pull request
Mar 18, 2022
apache#3721) Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Josh Elser <[email protected]>
apurtell
pushed a commit
to apurtell/hbase
that referenced
this pull request
Mar 19, 2022
apache#3721) Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Josh Elser <[email protected]>
apurtell
pushed a commit
to apurtell/hbase
that referenced
this pull request
Mar 25, 2022
apache#3721) Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Josh Elser <[email protected]>
apurtell
pushed a commit
to apurtell/hbase
that referenced
this pull request
Mar 26, 2022
apache#3721) Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Josh Elser <[email protected]>
apurtell
added a commit
to apurtell/hbase
that referenced
this pull request
Mar 26, 2022
…others) to branch-2.5 Previous cherry picks: commit 6aaef89 HBASE-26064 Introduce a StoreFileTracker to abstract the store file tracking logic commit 43b40e9 HBASE-25988 Store the store file list by a file apache#3578) commit 6e05376 HBASE-26079 Use StoreFileTracker when splitting and merging apache#3617) commit 090b2fe HBASE-26224 HBASE-26224 Introduce a MigrationStoreFileTracker to support migratin… apache#3656) commit 0ee1689 HBASE-26246 Persist the StoreFileTracker configurations to TableDescriptor when creating table apache#3666) commit 2052e80 HBASE-26248 Should find a suitable way to let users specify the store… apache#3665) commit 5ff0f98 HBASE-26264 Add more checks to prevent misconfiguration on store file… apache#3681) commit fc4f6d1 HBASE-26280 HBASE-26280 Use store file tracker when snapshoting apache#3685) commit 06db852 HBASE-26326 CreateTableProcedure fails when FileBasedStoreFileTracker… apache#3721) commit e4e7cf8 HBASE-26386 Refactor StoreFileTracker implementations to expose the s… apache#3774) commit 08d1171 HBASE-26328 Clone snapshot doesn't load reference files into FILE SFT impl apache#3749) commit 8bec26e HBASE-26263 [Rolling Upgrading] Persist the StoreFileTracker configur… apache#3700) commit a288365 HBASE-26271: Cleanup the broken store files under data directory apache#3786) commit d00b5fa HBASE-26454 CreateTableProcedure still relies on temp dir and renames… apache#3845) commit 771e552 HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot commit f16b7b1 HBASE-26265 Update ref guide to mention the new store file tracker im… apache#3942) commit 755b3b4 HBASE-26585 Add SFT configuration to META table descriptor when creating META apache#3998) commit 39c42c7 HBASE-26639 The implementation of TestMergesSplitsAddToTracker is pro… apache#4010) commit 6e1f5b7 HBASE-26586 Should not rely on the global config when setting SFT implementation for a table while upgrading apache#4006) commit f1dd865 HBASE-26654 ModifyTableDescriptorProcedure shoud load TableDescriptor… apache#4034) commit 8fbc9a2 HBASE-26674 Should modify filesCompacting under storeWriteLock apache#4040) commit 5aa0fd2 HBASE-26675 Data race on Compactor.writer apache#4035) commit 3021c58 HBASE-26700 The way we bypass broken track file is not enough in Stor… apache#4055) commit a8b68c9 HBASE-26690 Modify FSTableDescriptors to not rely on renaming when wr… apache#4054) commit dffeb8e HBASE-26587 Introduce a new Admin API to change SFT implementation (#… apache#4080) commit b265fe5 HBASE-26673 Implement a shell command for change SFT implementation apache#4113) commit 4cdb380 HBASE-26640 Reimplement master local region initialization to better … apache#4111) commit 77bb153 HBASE-26707: Reduce number of renames during bulkload (apache#4066) apache#4122) commit a4b192e HBASE-26611 Changing SFT implementation on disabled table is dangerous apache#4082) commit d3629bb HBASE-26837 Set SFT config when creating TableDescriptor in TestClone… apache#4226) commit 541d748 HBASE-26881 Backport HBASE-25368 to branch-2 (apache#4267) Fixups for precommit error prone, checkstyle, and javadoc warnings after applying cherry picks. Signed-off-by: Josh Elser <[email protected]> Reviewed-by: Wellington Ramos Chevreuil <[email protected]>
apurtell
pushed a commit
that referenced
this pull request
Mar 26, 2022
#3721) Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Josh Elser <[email protected]>
apurtell
added a commit
that referenced
this pull request
Mar 26, 2022
…others) to branch-2.5 Previous cherry picks: commit 6aaef89 HBASE-26064 Introduce a StoreFileTracker to abstract the store file tracking logic commit 43b40e9 HBASE-25988 Store the store file list by a file #3578) commit 6e05376 HBASE-26079 Use StoreFileTracker when splitting and merging #3617) commit 090b2fe HBASE-26224 HBASE-26224 Introduce a MigrationStoreFileTracker to support migratin… #3656) commit 0ee1689 HBASE-26246 Persist the StoreFileTracker configurations to TableDescriptor when creating table #3666) commit 2052e80 HBASE-26248 Should find a suitable way to let users specify the store… #3665) commit 5ff0f98 HBASE-26264 Add more checks to prevent misconfiguration on store file… #3681) commit fc4f6d1 HBASE-26280 HBASE-26280 Use store file tracker when snapshoting #3685) commit 06db852 HBASE-26326 CreateTableProcedure fails when FileBasedStoreFileTracker… #3721) commit e4e7cf8 HBASE-26386 Refactor StoreFileTracker implementations to expose the s… #3774) commit 08d1171 HBASE-26328 Clone snapshot doesn't load reference files into FILE SFT impl #3749) commit 8bec26e HBASE-26263 [Rolling Upgrading] Persist the StoreFileTracker configur… #3700) commit a288365 HBASE-26271: Cleanup the broken store files under data directory #3786) commit d00b5fa HBASE-26454 CreateTableProcedure still relies on temp dir and renames… #3845) commit 771e552 HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot commit f16b7b1 HBASE-26265 Update ref guide to mention the new store file tracker im… #3942) commit 755b3b4 HBASE-26585 Add SFT configuration to META table descriptor when creating META #3998) commit 39c42c7 HBASE-26639 The implementation of TestMergesSplitsAddToTracker is pro… #4010) commit 6e1f5b7 HBASE-26586 Should not rely on the global config when setting SFT implementation for a table while upgrading #4006) commit f1dd865 HBASE-26654 ModifyTableDescriptorProcedure shoud load TableDescriptor… #4034) commit 8fbc9a2 HBASE-26674 Should modify filesCompacting under storeWriteLock #4040) commit 5aa0fd2 HBASE-26675 Data race on Compactor.writer #4035) commit 3021c58 HBASE-26700 The way we bypass broken track file is not enough in Stor… #4055) commit a8b68c9 HBASE-26690 Modify FSTableDescriptors to not rely on renaming when wr… #4054) commit dffeb8e HBASE-26587 Introduce a new Admin API to change SFT implementation (#… #4080) commit b265fe5 HBASE-26673 Implement a shell command for change SFT implementation #4113) commit 4cdb380 HBASE-26640 Reimplement master local region initialization to better … #4111) commit 77bb153 HBASE-26707: Reduce number of renames during bulkload (#4066) #4122) commit a4b192e HBASE-26611 Changing SFT implementation on disabled table is dangerous #4082) commit d3629bb HBASE-26837 Set SFT config when creating TableDescriptor in TestClone… #4226) commit 541d748 HBASE-26881 Backport HBASE-25368 to branch-2 (#4267) Fixups for precommit error prone, checkstyle, and javadoc warnings after applying cherry picks. Signed-off-by: Josh Elser <[email protected]> Reviewed-by: Wellington Ramos Chevreuil <[email protected]>
vinayakphegde
pushed a commit
to vinayakphegde/hbase
that referenced
this pull request
Apr 4, 2024
apache#3721) Amend HBASE-26326 - HBASE-21515 has been challenging to backport into this branch. For HBASE-26326, we actually only need the changes HBASE-21515 added to ReflectionUtils, so I had given up on attempting to bring in HBASE-21515 and am adding these required changes as an amend to HBASE-26326. Change-Id: I82e9e2f44a2b64fa0423531cd1775ce55a1e1607 Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Josh Elser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… is set in global config