HBASE-26079 Use StoreFileTracker when splitting and merging #3617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
requested changes
Aug 24, 2021
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/DefaultStoreFileTracker.java
Outdated
Show resolved
Hide resolved
| @@ -850,6 +877,7 @@ public void commitMergedRegion(final RegionInfo mergedRegionInfo) throws IOExcep | |||
| throw new IOException("Unable to rename " + mergedRegionTmpDir + " to " | |||
| + regionDir); | |||
| } | |||
| loadRegionFilesIntoStoreTracker(regionDir); | |||
There was a problem hiding this comment.
I think we should also get the file list from store file tracker instead of listing?
There was a problem hiding this comment.
These would not be in the tracker yet, as these are the links created in this split/merge operation.
There was a problem hiding this comment.
I mean, when splitting/merging, we will create the linked store files in memory, we should just use them to insert to the tracker, so we do not need to list again.
...main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileTrackerFactory.java
Outdated
Show resolved
Hide resolved
Sorry, missed your ping there. Let me take a look. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
…racking logic Signed-off-by: Wellington Chevreuil <[email protected]>
added 2 commits
August 25, 2021 11:33
Change-Id: I1801bd4d1078c5967e2f80646cb1d40be12d9829
Change-Id: I89326af60c4e19f6dff0a0c517b826b17947b264
…store trakcer Change-Id: If5431fea9326c30e932b74e563dabcabc2a82c2f
wchevreuil
force-pushed
the
HBASE-26079
branch
from
6d40c8d to
a66cecc
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Change-Id: I144a978fa4d2d35cdade60d98f5e6e7d503a49de
wchevreuil
force-pushed
the
HBASE-26079
branch
from
e92f501 to
888f140
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
reviewed
Aug 26, 2021
| trackerMap.computeIfAbsent(familyName, t -> { | ||
| ColumnFamilyDescriptorBuilder fDescBuilder = | ||
| ColumnFamilyDescriptorBuilder.newBuilder(Bytes.toBytes(familyName)); | ||
| return StoreFileTrackerFactory.create(conf, regionInfo.getTable(), true, |
There was a problem hiding this comment.
I think here when creating StoreFileTracker, we should use the modified Configuration instance where we also include the configurations declared in table description and family description, as you can set StoreEngine per table or family.
There was a problem hiding this comment.
Agreed. Had changed this on latest commit.
| HRegionFileSystem mergeRegionFs, RegionInfo mergedRegion) throws IOException { | ||
| final TableDescriptor htd = env.getMasterServices().getTableDescriptors() | ||
| .get(mergedRegion.getTable()); | ||
| List<Path> mergedFiles = new ArrayList<>(); | ||
| for (ColumnFamilyDescriptor hcd : htd.getColumnFamilies()) { | ||
| String family = hcd.getNameAsString(); | ||
| final Collection<StoreFileInfo> storeFiles = regionFs.getStoreFiles(family); |
There was a problem hiding this comment.
I think here we should use StoreFileTracker to get the file list, instead of loading from HRegionFileSystem?
There was a problem hiding this comment.
Yes, and same thing on splits. Had changed this on latest commit.
1) Changes to load files to split/merge from tracker, instead of listing from FS; 2) UT for above; 3) Changed tracker factory to load traker impl from CF first, then Table, then Configuration; Change-Id: I3a09afd28afe5fe6297b28dafa5dec0eca4c323c
wchevreuil
force-pushed
the
HBASE-26079
branch
from
4af7ec4 to
c39ad64
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Apache9
pushed a commit
that referenced
this pull request
Sep 8, 2021
Signed-off-by: Duo Zhang <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Sep 9, 2021
Signed-off-by: Duo Zhang <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Sep 12, 2021
Signed-off-by: Duo Zhang <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Sep 13, 2021
Signed-off-by: Duo Zhang <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Sep 14, 2021
Signed-off-by: Duo Zhang <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Oct 5, 2021
Signed-off-by: Duo Zhang <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Oct 14, 2021
Signed-off-by: Duo Zhang <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Oct 21, 2021
Signed-off-by: Duo Zhang <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Nov 6, 2021
Signed-off-by: Duo Zhang <[email protected]>
BukrosSzabolcs
pushed a commit
to BukrosSzabolcs/hbase
that referenced
this pull request
Nov 8, 2021
) Signed-off-by: Duo Zhang <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Nov 9, 2021
Signed-off-by: Duo Zhang <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Nov 27, 2021
Signed-off-by: Duo Zhang <[email protected]>
BukrosSzabolcs
pushed a commit
to BukrosSzabolcs/hbase
that referenced
this pull request
Dec 2, 2021
) Signed-off-by: Duo Zhang <[email protected]>
BukrosSzabolcs
pushed a commit
to BukrosSzabolcs/hbase
that referenced
this pull request
Dec 2, 2021
) Signed-off-by: Duo Zhang <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Dec 6, 2021
Signed-off-by: Duo Zhang <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Dec 17, 2021
Signed-off-by: Duo Zhang <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Dec 22, 2021
Signed-off-by: Duo Zhang <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Jan 1, 2022
Signed-off-by: Duo Zhang <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Jan 2, 2022
Signed-off-by: Duo Zhang <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Jan 2, 2022
Signed-off-by: Duo Zhang <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Jan 4, 2022
Signed-off-by: Duo Zhang <[email protected]>
apurtell
added a commit
to apurtell/hbase
that referenced
this pull request
Mar 18, 2022
) Signed-off-by: Duo Zhang <[email protected]> Conflicts: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStoreFile.java
apurtell
added a commit
to apurtell/hbase
that referenced
this pull request
Mar 19, 2022
) Signed-off-by: Duo Zhang <[email protected]> Conflicts: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStoreFile.java
apurtell
added a commit
to apurtell/hbase
that referenced
this pull request
Mar 25, 2022
) Signed-off-by: Duo Zhang <[email protected]> Conflicts: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStoreFile.java
apurtell
added a commit
to apurtell/hbase
that referenced
this pull request
Mar 26, 2022
) Signed-off-by: Duo Zhang <[email protected]> Conflicts: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStoreFile.java
apurtell
added a commit
to apurtell/hbase
that referenced
this pull request
Mar 26, 2022
…others) to branch-2.5 Previous cherry picks: commit 6aaef89 HBASE-26064 Introduce a StoreFileTracker to abstract the store file tracking logic commit 43b40e9 HBASE-25988 Store the store file list by a file apache#3578) commit 6e05376 HBASE-26079 Use StoreFileTracker when splitting and merging apache#3617) commit 090b2fe HBASE-26224 HBASE-26224 Introduce a MigrationStoreFileTracker to support migratin… apache#3656) commit 0ee1689 HBASE-26246 Persist the StoreFileTracker configurations to TableDescriptor when creating table apache#3666) commit 2052e80 HBASE-26248 Should find a suitable way to let users specify the store… apache#3665) commit 5ff0f98 HBASE-26264 Add more checks to prevent misconfiguration on store file… apache#3681) commit fc4f6d1 HBASE-26280 HBASE-26280 Use store file tracker when snapshoting apache#3685) commit 06db852 HBASE-26326 CreateTableProcedure fails when FileBasedStoreFileTracker… apache#3721) commit e4e7cf8 HBASE-26386 Refactor StoreFileTracker implementations to expose the s… apache#3774) commit 08d1171 HBASE-26328 Clone snapshot doesn't load reference files into FILE SFT impl apache#3749) commit 8bec26e HBASE-26263 [Rolling Upgrading] Persist the StoreFileTracker configur… apache#3700) commit a288365 HBASE-26271: Cleanup the broken store files under data directory apache#3786) commit d00b5fa HBASE-26454 CreateTableProcedure still relies on temp dir and renames… apache#3845) commit 771e552 HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot commit f16b7b1 HBASE-26265 Update ref guide to mention the new store file tracker im… apache#3942) commit 755b3b4 HBASE-26585 Add SFT configuration to META table descriptor when creating META apache#3998) commit 39c42c7 HBASE-26639 The implementation of TestMergesSplitsAddToTracker is pro… apache#4010) commit 6e1f5b7 HBASE-26586 Should not rely on the global config when setting SFT implementation for a table while upgrading apache#4006) commit f1dd865 HBASE-26654 ModifyTableDescriptorProcedure shoud load TableDescriptor… apache#4034) commit 8fbc9a2 HBASE-26674 Should modify filesCompacting under storeWriteLock apache#4040) commit 5aa0fd2 HBASE-26675 Data race on Compactor.writer apache#4035) commit 3021c58 HBASE-26700 The way we bypass broken track file is not enough in Stor… apache#4055) commit a8b68c9 HBASE-26690 Modify FSTableDescriptors to not rely on renaming when wr… apache#4054) commit dffeb8e HBASE-26587 Introduce a new Admin API to change SFT implementation (#… apache#4080) commit b265fe5 HBASE-26673 Implement a shell command for change SFT implementation apache#4113) commit 4cdb380 HBASE-26640 Reimplement master local region initialization to better … apache#4111) commit 77bb153 HBASE-26707: Reduce number of renames during bulkload (apache#4066) apache#4122) commit a4b192e HBASE-26611 Changing SFT implementation on disabled table is dangerous apache#4082) commit d3629bb HBASE-26837 Set SFT config when creating TableDescriptor in TestClone… apache#4226) commit 541d748 HBASE-26881 Backport HBASE-25368 to branch-2 (apache#4267) Fixups for precommit error prone, checkstyle, and javadoc warnings after applying cherry picks. Signed-off-by: Josh Elser <[email protected]> Reviewed-by: Wellington Ramos Chevreuil <[email protected]>
apurtell
added a commit
that referenced
this pull request
Mar 26, 2022
Signed-off-by: Duo Zhang <[email protected]> Conflicts: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStoreFile.java
apurtell
added a commit
that referenced
this pull request
Mar 26, 2022
…others) to branch-2.5 Previous cherry picks: commit 6aaef89 HBASE-26064 Introduce a StoreFileTracker to abstract the store file tracking logic commit 43b40e9 HBASE-25988 Store the store file list by a file #3578) commit 6e05376 HBASE-26079 Use StoreFileTracker when splitting and merging #3617) commit 090b2fe HBASE-26224 HBASE-26224 Introduce a MigrationStoreFileTracker to support migratin… #3656) commit 0ee1689 HBASE-26246 Persist the StoreFileTracker configurations to TableDescriptor when creating table #3666) commit 2052e80 HBASE-26248 Should find a suitable way to let users specify the store… #3665) commit 5ff0f98 HBASE-26264 Add more checks to prevent misconfiguration on store file… #3681) commit fc4f6d1 HBASE-26280 HBASE-26280 Use store file tracker when snapshoting #3685) commit 06db852 HBASE-26326 CreateTableProcedure fails when FileBasedStoreFileTracker… #3721) commit e4e7cf8 HBASE-26386 Refactor StoreFileTracker implementations to expose the s… #3774) commit 08d1171 HBASE-26328 Clone snapshot doesn't load reference files into FILE SFT impl #3749) commit 8bec26e HBASE-26263 [Rolling Upgrading] Persist the StoreFileTracker configur… #3700) commit a288365 HBASE-26271: Cleanup the broken store files under data directory #3786) commit d00b5fa HBASE-26454 CreateTableProcedure still relies on temp dir and renames… #3845) commit 771e552 HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot commit f16b7b1 HBASE-26265 Update ref guide to mention the new store file tracker im… #3942) commit 755b3b4 HBASE-26585 Add SFT configuration to META table descriptor when creating META #3998) commit 39c42c7 HBASE-26639 The implementation of TestMergesSplitsAddToTracker is pro… #4010) commit 6e1f5b7 HBASE-26586 Should not rely on the global config when setting SFT implementation for a table while upgrading #4006) commit f1dd865 HBASE-26654 ModifyTableDescriptorProcedure shoud load TableDescriptor… #4034) commit 8fbc9a2 HBASE-26674 Should modify filesCompacting under storeWriteLock #4040) commit 5aa0fd2 HBASE-26675 Data race on Compactor.writer #4035) commit 3021c58 HBASE-26700 The way we bypass broken track file is not enough in Stor… #4055) commit a8b68c9 HBASE-26690 Modify FSTableDescriptors to not rely on renaming when wr… #4054) commit dffeb8e HBASE-26587 Introduce a new Admin API to change SFT implementation (#… #4080) commit b265fe5 HBASE-26673 Implement a shell command for change SFT implementation #4113) commit 4cdb380 HBASE-26640 Reimplement master local region initialization to better … #4111) commit 77bb153 HBASE-26707: Reduce number of renames during bulkload (#4066) #4122) commit a4b192e HBASE-26611 Changing SFT implementation on disabled table is dangerous #4082) commit d3629bb HBASE-26837 Set SFT config when creating TableDescriptor in TestClone… #4226) commit 541d748 HBASE-26881 Backport HBASE-25368 to branch-2 (#4267) Fixups for precommit error prone, checkstyle, and javadoc warnings after applying cherry picks. Signed-off-by: Josh Elser <[email protected]> Reviewed-by: Wellington Ramos Chevreuil <[email protected]>
vinayakphegde
pushed a commit
to vinayakphegde/hbase
that referenced
this pull request
Apr 4, 2024
) Signed-off-by: Duo Zhang <[email protected]> Change-Id: I5e09f8cf9cc6511b47f68b9a7144831dc202be85
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.