Remove duplicate trailingComma setting from .prettierrc.js #1836 #4316
Conversation
Fixed issue with .prettierrc.js containing trailingComma twice by removing 'none' value.
|
Hey @justinmclean, I've fixed the build error. Could you please review the changes? |
| return "Cannot build ConfElement, some of required attributes are not set " + attributes; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Hi @Jash2606 is this file you wanted or you added mistakenly?
There was a problem hiding this comment.
Hello @jerryshao , I got this file while running up the prettier , So Should i keep it or remove it ?
There was a problem hiding this comment.
I don't know who generates this file, from my point it is not necessary.
|
Hi @Jash2606 would you please fix the conflict of this PR, thanks. |
|
@Jash2606 The latter one takes effect when duplicate trailingComma, you can remove the |
|
@ Jash2606 It would be easier to review if the PR if it just fixed the above issue without making other changes. Any chance you can remove your formating changes? |
Fixed issue with .prettierrc.js containing trailingComma twice by removing 'none' value.
What changes were proposed in this pull request?
This pull request fixes the issue with
.prettierrc.jscontaining thetrailingCommasetting twice with different values by removing thenonevalue and keeping thees5value.Why are the changes needed?
The changes are needed to resolve the conflict in the Prettier configuration and ensure consistent code formatting according to ES5 rules.
Fix: #1836
Does this PR introduce any user-facing change?
No, this PR does not introduce any user-facing changes.
How was this patch tested?
The changes were tested by running Prettier on the codebase.