Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate trailingComma setting from .prettierrc.js #1836 #4316

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/ISSUE_TEMPLATE/bug-report.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
name: Bug Report
title: "[Bug report] "
description: A bug report issue
labels: [ "bug" ]
labels: ["bug"]
body:

- type: dropdown
id: version
attributes:
Expand Down
3 changes: 1 addition & 2 deletions .github/ISSUE_TEMPLATE/epic.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
name: Epic
title: "[EPIC] "
description: An epic issue with multiple sub-tasks
labels: [ "epic" ]
labels: ["epic"]
body:

- type: textarea
attributes:
label: Describe the proposal
Expand Down
3 changes: 1 addition & 2 deletions .github/ISSUE_TEMPLATE/feature-request.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
name: Feature Request
title: "[FEATURE] "
description: Suggest an idea for Gravitino
labels: [ "feature" ]
labels: ["feature"]
body:

- type: textarea
attributes:
label: Describe the feature
Expand Down
3 changes: 1 addition & 2 deletions .github/ISSUE_TEMPLATE/improvement.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@
name: Improvement
title: "[Improvement] "
description: Suggest an improvement on performance, code quality, user experience, etc
labels: [ "improvement" ]
labels: ["improvement"]
body:

- type: textarea
attributes:
label: What would you like to be improved?
Expand Down
3 changes: 1 addition & 2 deletions .github/ISSUE_TEMPLATE/subtask.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
name: Subtask
title: "[Subtask] "
description: A subtask issue
labels: [ "subtask" ]
labels: ["subtask"]
body:

- type: textarea
attributes:
label: Describe the subtask
Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/backend-integration-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ name: Backend Integration Test
on:
# Triggers the workflow on push or pull request events but only for the "main" branch
push:
branches: [ "main", "branch-*" ]
branches: ["main", "branch-*"]
pull_request:
branches: [ "main", "branch-*" ]
branches: ["main", "branch-*"]

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
Expand Down Expand Up @@ -60,9 +60,9 @@ jobs:
strategy:
matrix:
architecture: [linux/amd64]
java-version: [ 8, 11, 17 ]
test-mode: [ embedded, deploy ]
backend: [ mysql, h2]
java-version: [8, 11, 17]
test-mode: [embedded, deploy]
backend: [mysql, h2]
env:
PLATFORM: ${{ matrix.architecture }}
steps:
Expand All @@ -71,8 +71,8 @@ jobs:
- uses: actions/setup-java@v4
with:
java-version: ${{ matrix.java-version }}
distribution: 'temurin'
cache: 'gradle'
distribution: "temurin"
cache: "gradle"

- name: Set up QEMU
uses: docker/setup-qemu-action@v2
Expand All @@ -82,7 +82,7 @@ jobs:
dev/ci/check_commands.sh

- name: Package Gravitino
if : ${{ matrix.test-mode == 'deploy' }}
if: ${{ matrix.test-mode == 'deploy' }}
run: |
./gradlew compileDistribution -x test -PjdkVersion=${{ matrix.java-version }}

Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ name: build
on:
# Triggers the workflow on push or pull request events but only for the "main" branch
push:
branches: [ "main", "branch-*" ]
branches: ["main", "branch-*"]
pull_request:
branches: [ "main", "branch-*" ]
branches: ["main", "branch-*"]

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
Expand Down Expand Up @@ -62,8 +62,8 @@ jobs:
- uses: actions/setup-java@v4
with:
java-version: 8
distribution: 'temurin'
cache: 'gradle'
distribution: "temurin"
cache: "gradle"

- name: Build with Gradle
run: ./gradlew build -x test -PjdkVersion=8
Expand All @@ -73,7 +73,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
java-version: [ 8, 11, 17 ]
java-version: [8, 11, 17]
timeout-minutes: 30
needs: changes
if: needs.changes.outputs.source_changes == 'true'
Expand All @@ -85,8 +85,8 @@ jobs:
- uses: actions/setup-java@v4
with:
java-version: ${{ matrix.java-version }}
distribution: 'temurin'
cache: 'gradle'
distribution: "temurin"
cache: "gradle"

- name: Test publish to local
run: ./gradlew publishToMavenLocal -x test -PjdkVersion=${{ matrix.java-version }}
Expand Down
11 changes: 5 additions & 6 deletions .github/workflows/cron-integration-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Cron Integration Test
# Controls when the workflow will run
on:
schedule: # Runs by default on main branch
- cron: '0 19 * * *' # Runs every day at 19:00 PM UTC, equal to 03:00 AM the next day in GMT+8 time zone
- cron: "0 19 * * *" # Runs every day at 19:00 PM UTC, equal to 03:00 AM the next day in GMT+8 time zone

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
Expand Down Expand Up @@ -55,8 +55,8 @@ jobs:
strategy:
matrix:
architecture: [linux/amd64]
java-version: [ 8, 11, 17 ]
test-mode: [ embedded, deploy ]
java-version: [8, 11, 17]
test-mode: [embedded, deploy]
env:
DOCKER_RUN_NAME: hive-amd64
PLATFORM: ${{ matrix.architecture }}
Expand All @@ -66,9 +66,8 @@ jobs:
- uses: actions/setup-java@v4
with:
java-version: ${{ matrix.java-version }}
distribution: 'temurin'
cache: 'gradle'

distribution: "temurin"
cache: "gradle"

- name: Set up QEMU
uses: docker/setup-qemu-action@v2
Expand Down
32 changes: 16 additions & 16 deletions .github/workflows/docker-image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,25 +5,25 @@ on:
inputs:
image:
type: choice
description: 'Choose the image to build'
description: "Choose the image to build"
required: true
default: 'gravitino'
default: "gravitino"
options:
- 'gravitino'
- 'gravitino-ci-hive'
- 'gravitino-ci-kerberos-hive'
- 'gravitino-ci-trino'
- 'gravitino-ci-doris'
- 'gravitino-ci-ranger'
- 'trino'
- 'hive'
- 'ranger'
- "gravitino"
- "gravitino-ci-hive"
- "gravitino-ci-kerberos-hive"
- "gravitino-ci-trino"
- "gravitino-ci-doris"
- "gravitino-ci-ranger"
- "trino"
- "hive"
- "ranger"
tag:
description: 'Docker tag to apply to this image'
description: "Docker tag to apply to this image"
required: true
type: string
token:
description: 'Publish Docker token'
description: "Publish Docker token"
required: true
type: string

Expand Down Expand Up @@ -89,11 +89,11 @@ jobs:

- uses: actions/setup-java@v3
with:
java-version: '8'
distribution: 'temurin'
java-version: "8"
distribution: "temurin"

- name: Build and Push the Docker image
run: |
run: |
sudo rm -rf /usr/local/lib/android
sudo rm -rf /opt/hostedtoolcache/CodeQL
./dev/docker/build-docker.sh --platform all --type ${image_type} --image ${image_name} --tag ${{ github.event.inputs.tag }} --latest
12 changes: 6 additions & 6 deletions .github/workflows/flink-integration-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ name: Flink Integration Test
on:
# Triggers the workflow on push or pull request events but only for the "main" branch
push:
branches: [ "main", "branch-*" ]
branches: ["main", "branch-*"]
pull_request:
branches: [ "main", "branch-*" ]
branches: ["main", "branch-*"]

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
Expand Down Expand Up @@ -56,7 +56,7 @@ jobs:
strategy:
matrix:
architecture: [linux/amd64]
java-version: [ 8, 11, 17 ]
java-version: [8, 11, 17]
env:
PLATFORM: ${{ matrix.architecture }}
steps:
Expand All @@ -65,8 +65,8 @@ jobs:
- uses: actions/setup-java@v4
with:
java-version: ${{ matrix.java-version }}
distribution: 'temurin'
cache: 'gradle'
distribution: "temurin"
cache: "gradle"

- name: Set up QEMU
uses: docker/setup-qemu-action@v2
Expand Down Expand Up @@ -101,4 +101,4 @@ jobs:
distribution/package/logs/gravitino-server.out
distribution/package/logs/gravitino-server.log
catalogs/**/*.log
catalogs/**/*.tar
catalogs/**/*.tar
12 changes: 6 additions & 6 deletions .github/workflows/frontend-integration-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ name: Frontend Integration Test
on:
# Triggers the workflow on push or pull request events but only for the "main" branch
push:
branches: [ "main", "branch-*" ]
branches: ["main", "branch-*"]
pull_request:
branches: [ "main", "branch-*" ]
branches: ["main", "branch-*"]

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
Expand Down Expand Up @@ -59,7 +59,7 @@ jobs:
strategy:
matrix:
architecture: [linux/amd64]
java-version: [ 8 ]
java-version: [8]
env:
PLATFORM: ${{ matrix.architecture }}
steps:
Expand All @@ -68,8 +68,8 @@ jobs:
- uses: actions/setup-java@v4
with:
java-version: ${{ matrix.java-version }}
distribution: 'temurin'
cache: 'gradle'
distribution: "temurin"
cache: "gradle"

- name: Set up QEMU
uses: docker/setup-qemu-action@v2
Expand Down Expand Up @@ -104,4 +104,4 @@ jobs:
distribution/package/logs/gravitino-server.out
distribution/package/logs/gravitino-server.log
catalogs/**/*.log
catalogs/**/*.tar
catalogs/**/*.tar
12 changes: 6 additions & 6 deletions .github/workflows/python-integration-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ name: Python Client Integration Test
on:
# Triggers the workflow on push or pull request events but only for the "main" branch
push:
branches: [ "main", "branch-*" ]
branches: ["main", "branch-*"]
pull_request:
branches: [ "main", "branch-*" ]
branches: ["main", "branch-*"]

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
Expand Down Expand Up @@ -43,7 +43,7 @@ jobs:
strategy:
matrix:
architecture: [linux/amd64]
java-version: [ 8 ]
java-version: [8]
env:
PLATFORM: ${{ matrix.architecture }}
steps:
Expand All @@ -52,8 +52,8 @@ jobs:
- uses: actions/setup-java@v4
with:
java-version: ${{ matrix.java-version }}
distribution: 'temurin'
cache: 'gradle'
distribution: "temurin"
cache: "gradle"

- name: Set up QEMU
uses: docker/setup-qemu-action@v2
Expand Down Expand Up @@ -82,4 +82,4 @@ jobs:
distribution/package/logs/gravitino-server.out
distribution/package/logs/gravitino-server.log
catalogs/**/*.log
catalogs/**/*.tar
catalogs/**/*.tar
16 changes: 8 additions & 8 deletions .github/workflows/spark-integration-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ name: Spark Integration Test
on:
# Triggers the workflow on push or pull request events but only for the "main" branch
push:
branches: [ "main", "branch-*" ]
branches: ["main", "branch-*"]
pull_request:
branches: [ "main", "branch-*" ]
branches: ["main", "branch-*"]

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
Expand Down Expand Up @@ -57,9 +57,9 @@ jobs:
strategy:
matrix:
architecture: [linux/amd64]
java-version: [ 8, 11, 17 ]
scala-version: [ 2.12 ]
test-mode: [ embedded, deploy ]
java-version: [8, 11, 17]
scala-version: [2.12]
test-mode: [embedded, deploy]
env:
PLATFORM: ${{ matrix.architecture }}
steps:
Expand All @@ -68,8 +68,8 @@ jobs:
- uses: actions/setup-java@v4
with:
java-version: ${{ matrix.java-version }}
distribution: 'temurin'
cache: 'gradle'
distribution: "temurin"
cache: "gradle"

- name: Set up QEMU
uses: docker/setup-qemu-action@v2
Expand All @@ -79,7 +79,7 @@ jobs:
dev/ci/check_commands.sh

- name: Package Gravitino
if : ${{ matrix.test-mode == 'deploy' }}
if: ${{ matrix.test-mode == 'deploy' }}
run: |
./gradlew compileDistribution -x test -PjdkVersion=${{ matrix.java-version }}

Expand Down
Loading
Loading