Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] .prettierrc.js contains trailingComma twice #1836

Open
justinmclean opened this issue Feb 1, 2024 · 4 comments · May be fixed by #4316
Open

[Improvement] .prettierrc.js contains trailingComma twice #1836

justinmclean opened this issue Feb 1, 2024 · 4 comments · May be fixed by #4316
Assignees
Labels
good first issue Good for newcomers improvement Improvements on everything

Comments

@justinmclean
Copy link
Member

What would you like to be improved?

.prettierrc.js contains trailingComma twice with different values

 trailingComma: 'es5',
 trailingComma: 'none'

How should we improve?

No response

@justinmclean justinmclean added good first issue Good for newcomers improvement Improvements on everything labels Feb 1, 2024
@jerryshao jerryshao modified the milestone: Gravitino 0.4.0 Feb 1, 2024
@SahilThakur02
Copy link

@justinmclean What do you wish to fix? Remove one of it or use

module.exports = {
  trailingComma: ['none', 'es5'] // Add both values as elements of an array
};

instead?

@Jash2606
Copy link

Hey @jerryshao , I would like to work on this issue. please could you assign me this issue?

@Jash2606
Copy link

Hey @justinmclean,

Should I remove one of the trailingComma values (probably 'none'), or should I try to combine them somehow?

@justinmclean
Copy link
Member Author

I'm not an expert on this, but I think we would only need one, e.g. es5 - however, it may be that that might cause the build to fail.

Jash2606 pushed a commit to Jash2606/gravitino that referenced this issue Jul 30, 2024
Fixed issue with .prettierrc.js containing trailingComma twice by removing 'none' value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants