[#1328] fix(trino-connector): Fix the failed 'drop catalog' test on Trino image gravitino-ci-trino:0.1.3. #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryshao
added
need backport
yuqi1129
reviewed
Jan 5, 2024
| @@ -1001,7 +1001,7 @@ void testDropCatalogAndCreateAgain() throws InterruptedException { | |||
| createdMetalake.dropCatalog(NameIdentifier.of(metalakeName, catalogName)); | |||
| // We need to test we can't load this catalog any more by Trino. | |||
| success = checkTrinoHasRemoved(sql, 30); | |||
| Assertions.assertFalse(success, "Trino should not load the catalog any more: " + sql); | |||
| Assertions.assertTrue(success, "Trino should not load the catalog any more: " + sql); | |||
There was a problem hiding this comment.
Can you add some description about why the Trino image 0.1.3 brings these changes?
…for gravitino-ci-trino:0.1.3.
github-actions bot
pushed a commit
that referenced
this pull request
Jan 5, 2024
…rino image gravitino-ci-trino:0.1.3. (#1329) ### What changes were proposed in this pull request? Fix the failed 'drop catalog' test on Trino image gravitino-ci-trino:0.1.3. Trino image gravitino-ci-trino:0.1.2 use the gravitino-trino-connector-0.3.0-SNAPSHOT.jar, it does not support drop catalog, so the tester has made it compatible with this. Trino image gravitino-ci-trino:0.1.3 use the gravitino-trino-connector-0.4.0-SNAPSHOT.jar, it support drop catalog. the test did not pass. ### Why are the changes needed? Fix: #1328 ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? NO
diqiu50
added a commit
to diqiu50/gravitino
that referenced
this pull request
Jan 8, 2024
…t on Trino image gravitino-ci-trino:0.1.3. (apache#1329) ### What changes were proposed in this pull request? Fix the failed 'drop catalog' test on Trino image gravitino-ci-trino:0.1.3. Trino image gravitino-ci-trino:0.1.2 use the gravitino-trino-connector-0.3.0-SNAPSHOT.jar, it does not support drop catalog, so the tester has made it compatible with this. Trino image gravitino-ci-trino:0.1.3 use the gravitino-trino-connector-0.4.0-SNAPSHOT.jar, it support drop catalog. the test did not pass. ### Why are the changes needed? Fix: apache#1328 ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? NO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix the failed 'drop catalog' test on Trino image gravitino-ci-trino:0.1.3.
Trino image gravitino-ci-trino:0.1.2 use the gravitino-trino-connector-0.3.0-SNAPSHOT.jar, it does not support drop catalog, so the tester has made it compatible with this.
Trino image gravitino-ci-trino:0.1.3 use the gravitino-trino-connector-0.4.0-SNAPSHOT.jar, it support drop catalog.
the test did not pass.
Why are the changes needed?
Fix: #1328
Does this PR introduce any user-facing change?
NO
How was this patch tested?
NO