Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1328] fix(trino-connector): Fix the failed 'drop catalog' test on Trino image gravitino-ci-trino:0.1.3. #1329

Merged
merged 3 commits into from
Jan 5, 2024
Merged

[#1328] fix(trino-connector): Fix the failed 'drop catalog' test on Trino image gravitino-ci-trino:0.1.3. #1329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
775072b
Fix bug of failed to run the 'Drop catalog' test on the Docker image …
diqiu50 Jan 4, 2024
27e5ee4
Fix failed to run the testIcebergCatalogCreatedByGravitino tester.
diqiu50 Jan 5, 2024
40145ac
Merge branch 'main' into fix-1328
diqiu50 Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion integration-test/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ tasks.test {

// Gravitino CI Docker image
environment("GRAVITINO_CI_HIVE_DOCKER_IMAGE", "datastrato/gravitino-ci-hive:0.1.7")
environment("GRAVITINO_CI_TRINO_DOCKER_IMAGE", "datastrato/gravitino-ci-trino:0.1.2")
environment("GRAVITINO_CI_TRINO_DOCKER_IMAGE", "datastrato/gravitino-ci-trino:0.1.3")

val testMode = project.properties["testMode"] as? String ?: "embedded"
systemProperty("gravitino.log.path", buildDir.path + "/integration-test.log")
Expand Down
5 changes: 3 additions & 2 deletions ...-test/src/test/java/com/datastrato/gravitino/integration/test/trino/TrinoConnectorIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -858,7 +858,8 @@ void testIcebergCatalogCreatedByGravitino() throws InterruptedException {
final String sql1 =
String.format("drop schema \"%s.%s\".%s cascade", metalakeName, catalogName, schemaName);
// Will fail because the iceberg catalog does not support cascade drop
containerSuite.getTrinoContainer().executeUpdateSQL(sql1);
Assertions.assertThrows(
RuntimeException.class, () -> containerSuite.getTrinoContainer().executeUpdateSQL(sql1));

final String sql2 =
String.format("show schemas in \"%s.%s\" like '%s'", metalakeName, catalogName, schemaName);
Expand Down Expand Up @@ -1038,7 +1039,7 @@ void testDropCatalogAndCreateAgain() throws InterruptedException {
createdMetalake.dropCatalog(NameIdentifier.of(metalakeName, catalogName));
// We need to test we can't load this catalog any more by Trino.
success = checkTrinoHasRemoved(sql, 30);
Assertions.assertFalse(success, "Trino should not load the catalog any more: " + sql);
Assertions.assertTrue(success, "Trino should not load the catalog any more: " + sql);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some description about why the Trino image 0.1.3 brings these changes?

}
}

Expand Down
Loading