Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1317] fix(trino-connector): Support Fixed type conversion #1318

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

yuqi1129
Copy link
Contributor

@yuqi1129 yuqi1129 commented Jan 4, 2024

What changes were proposed in this pull request?

  1. Suppoort type 'Fixed' in Trino connector GeneralDataTypeTransformer

Why are the changes needed?

Fixed type is needed by Iceberg type.

Fix: #1317

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

IT.

@jerryshao jerryshao added need backport Issues that need to backport to another branch branch-0.3 labels Jan 4, 2024
@yuqi1129 yuqi1129 self-assigned this Jan 5, 2024
@jerryshao
Copy link
Contributor

@yuqi1129 would you please fix build issue, thanks.

@yuqi1129
Copy link
Contributor Author

yuqi1129 commented Jan 5, 2024

@yuqi1129 would you please fix build issue, thanks.

@jerryshao
#1329 will fix it. Perhaps we should merge it first.

@jerryshao
Copy link
Contributor

ok

@yuqi1129 yuqi1129 requested review from diqiu50 and jerryshao January 5, 2024 09:23
@jerryshao jerryshao changed the title [#1317] fix: Support Fixed type conversion [#1317] fix(trino-connector): Support Fixed type conversion Jan 5, 2024
@jerryshao jerryshao requested a review from diqiu50 January 5, 2024 11:34
Copy link
Contributor

@diqiu50 diqiu50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerryshao jerryshao merged commit 6544417 into apache:main Jan 8, 2024
11 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 8, 2024
### What changes were proposed in this pull request?

1. Suppoort type 'Fixed' in Trino connector `GeneralDataTypeTransformer`
 
### Why are the changes needed?

Fixed type is needed by Iceberg type.

Fix: #1317 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

IT.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-0.3 need backport Issues that need to backport to another branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug report] Support Fixed type conversion Gravitino and Trino
3 participants