-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: explicitly list out all Expr types in TypeCoercionRewriter::mutate #9038
Conversation
The CI failure was fixed in #9034 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @guojidan -- this is a nice improvement
| Expr::SimilarTo(_) | ||
| Expr::IsNotNull(_) | ||
| Expr::IsNull(_) | ||
| Expr::Negative(_) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 looks like there are some other bugs here;
❯ select -'100';
Internal error: Can't create negative physical expr for (- 'Literal { value: Utf8("100") }'), the type of child expr is Utf8, not signed numeric.
This was likely caused by a bug in DataFusion's code and we would welcome that you file an bug report in our issue tracker
❯ select -'100'::int;
+-----------------+
| (- Utf8("100")) |
+-----------------+
| -100 |
+-----------------+
I will file another ticket -- #9060
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @guojidan -- this is awesome. Even better it helped find another bug 🎉
Which issue does this PR close?
Closes #8990 .
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?