Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explicitly list out all Expr types in TypeCoercionRewriter::mutate #8990

Closed
guojidan opened this issue Jan 25, 2024 · 2 comments · Fixed by #9038
Closed

explicitly list out all Expr types in TypeCoercionRewriter::mutate #8990

guojidan opened this issue Jan 25, 2024 · 2 comments · Fixed by #9038

Comments

@guojidan
Copy link
Contributor 

          It might make sense to remove the catch all  from this `match` expression

https://github.com/apache/arrow-datafusion/blob/bc0ba6a724aaaf312b770451718cbce696de6640/datafusion/optimizer/src/analyzer/type_coercion.rs#L413

And explicitly list out all Expr types so that we don't accidentally another Expr type in the future

Is that something you might be willing to do in another PR @guojidan ?

Originally posted by @alamb in #8982 (comment)
@guojidan
Copy link
Contributor Author

wait #8982 merged

@alamb
Copy link
Contributor

alamb commented Jan 25, 2024

wait #8982 merged

Sorry for the delay, #8982 is now merged

@guojidan guojidan mentioned this issue Jan 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Chore: explicitly list out all Expr types in TypeCoercionRewriter::mutate guojidan/arrow-datafusion
2 participants
@alamb @guojidan