Fix the clippy error of use of deprecated method

[viirya]

Which issue does this PR close?

Closes #.

Rationale for this change

Currently the CI failed (https://github.com/apache/arrow-datafusion/actions/runs/7688676073/job/20950251248?pr=9031) because:

error: use of deprecated method `indexmap::IndexSet::<T, S>::remove`: `remove` disrupts the set order -- use `swap_remove` or `shift_remove` for explicit behavior.
   --> datafusion/physical-expr/src/equivalence/properties.rs:733:32
    |
733 |                 search_indices.remove(idx);
    |                                ^^^^^^
    |
    = note: `-D deprecated` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(deprecated)]`

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

[viirya]

cc @alamb

[mustafasrepo]

LGTM!

[viirya]

Thanks @mustafasrepo