Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split expression pf planner into one part. #4783

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

jackwener
Copy link
Member

Which issue does this PR close?

Part of #4392.

I'm try into add Binder in planner, split the planner is a good begin for it. So I do it previously.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the sql SQL Planner label Dec 31, 2022
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jackwener -- this looks great. 🙏 the planner is in desperate need of some cleaning up

Something else that would help I think is to move the tests from datafusion/sql/src/planner.rs into datafusion/sql/test/planner.rs or similar to help parallelize the test compilation

Sadly I have just created a bunch of conflicts in in #4779 (also related to shrinking the planner)

Also related (and conflicting): #4785 #4787

@jackwener
Copy link
Member Author

Thank you @jackwener -- this looks great. 🙏 the planner is in desperate need of some cleaning up

Something else that would help I think is to move the tests from datafusion/sql/src/planner.rs into datafusion/sql/test/planner.rs or similar to help parallelize the test compilation

Sadly I have just created a bunch of conflicts in in #4779 (also related to shrinking the planner)

Also related (and conflicting): #4785 #4787

I make this PR draft, I will wait for those PR merge.
Thanks @alamb remind

@jackwener jackwener marked this pull request as draft January 1, 2023 14:11
@alamb
Copy link
Contributor

alamb commented Jan 1, 2023

Thanks @alamb remind

Thank YOU!

@alamb
Copy link
Contributor

alamb commented Jan 2, 2023

#4785 #4787 are now both merged

@jackwener jackwener marked this pull request as ready for review January 3, 2023 04:09
@jackwener
Copy link
Member Author

#4785 #4787 are now both merged

Resolve conflict, thanks @alamb

Copy link
Contributor

@liukun4515 liukun4515 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
i would merge this pr first, otherwise there will be conflicts.

@liukun4515 liukun4515 merged commit 6c81c10 into apache:master Jan 3, 2023
@jackwener jackwener deleted the split_expr branch January 3, 2023 06:57
@ursabot
Copy link

ursabot commented Jan 3, 2023

Benchmark runs are scheduled for baseline = 00a22cb and contender = 6c81c10. 6c81c10 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb
Copy link
Contributor

alamb commented Jan 3, 2023

Thank you for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sql SQL Planner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants