Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: split the SQL planner into smaller modules #4392

Closed
jackwener opened this issue Nov 27, 2022 · 3 comments · Fixed by #4829
Closed

Enhancement: split the SQL planner into smaller modules #4392

jackwener opened this issue Nov 27, 2022 · 3 comments · Fixed by #4829
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jackwener
Copy link
Member

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
The current planner file is too large, we can split it.

Like

  • query.rs
  • select.rs
  • set_expr.rs
  • ....

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@jackwener jackwener added the enhancement New feature or request label Nov 27, 2022
@jackwener jackwener changed the title Proposal: split the planner Enhancement: split the planner Nov 27, 2022
@jackwener
Copy link
Member Author

Maybe we can add label good-first-issue

@alamb
Copy link
Contributor

alamb commented Nov 28, 2022

I agree this would be an excellent idea

The planner code I think is the code that translates from SQL statements to LogicalPlan: https://github.com/apache/arrow-datafusion/blob/a31b44eae236920d43ddd3ef7fadf8f9abf18976/datafusion/sql/src/planner.rs

@alamb alamb added good first issue Good for newcomers help wanted Extra attention is needed labels Nov 28, 2022
@alamb
Copy link
Contributor

alamb commented Nov 28, 2022

I agree this would be a good first issue as it will be mostly a software engineering exercise and doesn't require much datafusion internals knowledge. Thank you @jackwener

@alamb alamb changed the title Enhancement: split the planner Enhancement: split the SQL planner into smaller modules Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants